Skip to content

Extend the GPIO HAL API tests #11038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 24, 2019
Merged

Extend the GPIO HAL API tests #11038

merged 1 commit into from
Jul 24, 2019

Conversation

fkjagodzinski
Copy link
Member

@fkjagodzinski fkjagodzinski commented Jul 12, 2019 •
edited
Loading

Description

Use the MbedTester to verify the functions from https://github.com/ARMmbed/mbed-os/blob/master/hal/gpio_api.h.

Updated tests:

  • tests-mbed_hal_fpga_ci_test_shield-gpio.

NOTE This patch won't work without a gpio_pinmap() function added in #10644.

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[x] Test update
[ ] Breaking change

Reviewers

@jamesbeyond @mprse @maciejbocianski

Release Notes

@ciarmcom ciarmcom requested review from jamesbeyond, maciejbocianski, mprse and a team July 12, 2019 15:00
@ciarmcom
Copy link
Member

@fkjagodzinski, thank you for your changes.
@maciejbocianski @jamesbeyond @mprse @ARMmbed/mbed-os-hal @ARMmbed/mbed-os-test @ARMmbed/mbed-os-maintainers please review.

@fkjagodzinski
Copy link
Member Author

#10644 is merged now; this PR ready to proceed.

@SeppoTakalo
Copy link
Contributor

@ARMmbed/mbed-os-hal Please review.

@mbed-ci
Copy link

mbed-ci commented Jul 17, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

jamesbeyond
jamesbeyond approved these changes Jul 24, 2019
View reviewed changes
Copy link
Contributor

@jamesbeyond jamesbeyond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SeppoTakalo SeppoTakalo merged commit c5c7458 into ARMmbed:master Jul 24, 2019
@fkjagodzinski fkjagodzinski deleted the fpga_test-gpio branch July 24, 2019 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SeppoTakalo SeppoTakalo SeppoTakalo approved these changes

@jamesbeyond jamesbeyond jamesbeyond approved these changes

@maciejbocianski maciejbocianski Awaiting requested review from maciejbocianski

@mprse mprse Awaiting requested review from mprse

Assignees
No one assigned
Labels
release-version: 5.14.0-rc1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fkjagodzinski @ciarmcom @SeppoTakalo @mbed-ci @jamesbeyond