BLE: allow overriding event signal #11058
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pan-
approved these changes
Jul 16, 2019
|
@paul-szczepanek-arm, thank you for your changes. |
donatieng
approved these changes
Jul 16, 2019
|
Lgtm. @ARMmbed/mbed-os-maintainers Stareted CI since @paul-szczepanek-arm PM'd me, and I think y'all were already out. 😅 |
Test run: FAILEDSummary: 2 of 4 test jobs failed Failed test jobs:
|
|
CI restarted. |
Test run: FAILEDSummary: 1 of 11 test jobs failed Failed test jobs:
|
|
Aborted previous CI job and restarted |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
|
travis-ci/events restarted |
SeppoTakalo
approved these changes
Jul 17, 2019
SeppoTakalo
added
ready for merge
release-version: 5.14.0-rc1
and removed
needs: review
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Function that signals events from controller can not be overridden by porter. This changes makes it weak making it possible to decouple host from controller.
Pull request type
Reviewers
Release Notes
This makes no change to existing code and users. Only affects future porters.