Skip to content

Add a gpio-irq pinmap #11074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 29, 2019
Merged

Add a gpio-irq pinmap #11074

merged 5 commits into from
Jul 29, 2019

Conversation

fkjagodzinski
Copy link
Member

Description

This patch adds a gpio_irq_pinmap() function that is used for GPIO IRQ testing with the FPGA shield. This is a follow-up to #10644; the default implementation returns a PinMap that is exactly the same as GPIO PinMap. Every target has to override this weak implementation to provide a correct list of pins to test.

I also updated the tests-mbed_hal_fpga_ci_test_shield-gpio_irq test to make use of gpio_irq_pinmap().

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[x] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@mmahadevan108 @c1728p9 @maclobdell @maciejbocianski

Release Notes

Add a weak gpio_irq_pinmap(), that every target has to override, to provide a set of pins for GPIO IRQ testing.

@ciarmcom ciarmcom requested review from c1728p9, maciejbocianski, maclobdell and a team July 19, 2019 11:00
@ciarmcom
Copy link
Member

@fkjagodzinski, thank you for your changes.
@maclobdell @maciejbocianski @c1728p9 @ARMmbed/mbed-os-test @ARMmbed/mbed-os-hal @ARMmbed/mbed-os-maintainers please review.

maciejbocianski
maciejbocianski approved these changes Jul 19, 2019
View reviewed changes
Copy link
Contributor

@maciejbocianski maciejbocianski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mbed-ci
Copy link

mbed-ci commented Jul 22, 2019

Test run: FAILED

Summary: 3 of 4 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-GCC_ARM
  • jenkins-ci/mbed-os-ci_build-IAR
  • jenkins-ci/mbed-os-ci_build-ARM

@SeppoTakalo
Copy link
Contributor

@fkjagodzinski Please fix the build failures

[2019-07-22T13:58:20.820Z] [2019-07-22T13:58:20.820Z] [Error] objects.h@40,5: unknown type name 'gpio_irq_event'

[2019-07-22T13:58:20.820Z] [2019-07-22T13:58:20.820Z] [Error] objects.h@41,5: unknown type name 'gpio_irq_handler'

[2019-07-22T13:58:20.820Z] [2019-07-22T13:58:20.820Z] Failed to build library

Failed builds (at least):

  • FUTURE_SEQUANA ARM
  • FUTURE_SEQUANA_M0 ARM
  • GR_LYCHEE ARM
  • UBLOX_EVK_ODIN_W2 ARM

@fkjagodzinski
Copy link
Member Author

fkjagodzinski commented Jul 23, 2019 •
edited
Loading

Build failures should be fixed now.

@lrusinowicz Could you review the patch I made for PSOC6_FUTURE (8448640)?

@fkjagodzinski
Copy link
Member Author

travis-ci/events job failed with fragmenting_barrage_test: failed at line 92. I don't think this patch could interfere with events tests. I'm unable to reproduce this failure locally with make -C events/equeue/ test.

@SeppoTakalo could you restart that Travis job please?

Filip Jagodzinski added 5 commits July 25, 2019 10:56
Add HAL API for GPIO-IRQ pinmap
bd5ecaa
Add a sanity check for the GPIO-IRQ pinmap
0e40e89
Test: FPGA shield: Update the GPIO-IRQ API tests
5e17edd 
Use the gpio_irq_pinmap() for GPIO-IRQ testing.
Test: FPGA shield: Fix GPIO-IRQ test_utils.h
5ee22d0 
Include the gpio_irq_api header to fix build failures.
PSOC6_FUTURE: Fix circular dependency for GPIO-IRQ
8448640 
The use of `gpio_irq_event` & `gpio_irq_handler` in `gpio_irq_s` creates
a circular dependency.

hal/gpio_irq_api.h needs
targets/TARGET_Cypress/TARGET_PSOC6_FUTURE/TARGET_CY8C63XX/device.h, that needs
targets/TARGET_Cypress/TARGET_PSOC6_FUTURE/objects.h, that again needs
hal/gpio_irq_api.h, before the types are defined.

Remove `#include "gpio_irq_api.h"` directive from objects.h and change
the types of `gpio_irq_s` members.
@fkjagodzinski
Copy link
Member Author

Rebased to current master (c5c7458) and resolved conflicts.

@mbed-ci
Copy link

mbed-ci commented Jul 26, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 2
Build artifacts

@SeppoTakalo SeppoTakalo merged commit 417a9fe into ARMmbed:master Jul 29, 2019
@fkjagodzinski fkjagodzinski deleted the pinmap-gpio_irq branch August 13, 2019 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c1728p9 c1728p9 c1728p9 approved these changes

@SeppoTakalo SeppoTakalo SeppoTakalo approved these changes

@maciejbocianski maciejbocianski maciejbocianski approved these changes

@mprse mprse mprse approved these changes

@maclobdell maclobdell Awaiting requested review from maclobdell

Assignees
No one assigned
Labels
release-version: 5.14.0-rc1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@fkjagodzinski @ciarmcom @mbed-ci @SeppoTakalo @c1728p9 @maciejbocianski @mprse