Skip to content

NRF52840: fix include path issues for ble pal cordio ll and gcc #11078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 22, 2019

Conversation

bentcooke
Copy link
Contributor

Description

This PR fixes the include path for some of the Cordio LL source that was causing compile failures with GCC.

Example build failure without the include paths:

Compile [ 40.5%]: pal_bb_ble_rf.c
[Error] pal_bb_ble_rf.c@155,1: unknown type name 'bool_t'
[Error] pal_bb_ble_rf.c@160,10: 'TRUE' undeclared (first use in this function)
[Error] pal_bb_ble_rf.c@176,47: unknown type name 'bool_t'
[Warning] pal_bb_ble_rf.c@161,1: control reaches end of non-void function [-Wreturn-type]
[ERROR] ./mbed-os/features/FEATURE_BLE/targets/TARGET_NORDIC/TARGET_NORDIC_CORDIO/TARGET_NRF5x/stack/sources/pal_bb_ble_rf.c:155:1: error: unknown type name 'bool_t'
 bool_t PalRadioWriteRfPathComp(int16_t txPathComp, int16_t rxPathComp)
 ^~~~~~
./mbed-os/features/FEATURE_BLE/targets/TARGET_NORDIC/TARGET_NORDIC_CORDIO/TARGET_NRF5x/stack/sources/pal_bb_ble_rf.c: In function 'PalRadioWriteRfPathComp':
./mbed-os/features/FEATURE_BLE/targets/TARGET_NORDIC/TARGET_NORDIC_CORDIO/TARGET_NRF5x/stack/sources/pal_bb_ble_rf.c:160:10: error: 'TRUE' undeclared (first use in this function)
   return TRUE;
          ^~~~
./mbed-os/features/FEATURE_BLE/targets/TARGET_NORDIC/TARGET_NORDIC_CORDIO/TARGET_NRF5x/stack/sources/pal_bb_ble_rf.c:160:10: note: each undeclared identifier is reported only once for each function it appears in
./mbed-os/features/FEATURE_BLE/targets/TARGET_NORDIC/TARGET_NORDIC_CORDIO/TARGET_NRF5x/stack/sources/pal_bb_ble_rf.c: At top level:
./mbed-os/features/FEATURE_BLE/targets/TARGET_NORDIC/TARGET_NORDIC_CORDIO/TARGET_NRF5x/stack/sources/pal_bb_ble_rf.c:176:47: error: unknown type name 'bool_t'
 int8_t PalRadioGetActualTxPower(int8_t txPwr, bool_t compFlag)
                                               ^~~~~~
./mbed-os/features/FEATURE_BLE/targets/TARGET_NORDIC/TARGET_NORDIC_CORDIO/TARGET_NRF5x/stack/sources/pal_bb_ble_rf.c: In function 'PalRadioWriteRfPathComp':
./mbed-os/features/FEATURE_BLE/targets/TARGET_NORDIC/TARGET_NORDIC_CORDIO/TARGET_NRF5x/stack/sources/pal_bb_ble_rf.c:161:1: warning: control reaches end of non-void function [-Wreturn-type]

Pull request type

[x ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@pan- @paul-szczepanek-arm @donatieng

@0Grit
Copy link

0Grit commented Jul 19, 2019

@AGlass0fMilk

@ciarmcom ciarmcom requested review from donatieng, pan-, paul-szczepanek-arm and a team July 19, 2019 19:00
@ciarmcom
Copy link
Member

@bentcooke, thank you for your changes.
@donatieng @pan- @paul-szczepanek-arm @ARMmbed/mbed-os-pan @ARMmbed/mbed-os-maintainers please review.

@paul-szczepanek-arm
Copy link
Member

paul-szczepanek-arm commented Jul 22, 2019

As a general rule due to our tool limitation it's a good idea to qualify the headers with paths but I don't see how in this case the lack of paths was causing the problem. Is there a name clash for these headers?

@mbed-ci
Copy link

mbed-ci commented Jul 22, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants