Cellular: Add BG96 AT driver with DNS support #11082
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AriParkkila, thank you for your changes. |
SeppoTakalo
approved these changes
Jul 22, 2019
bulislaw
approved these changes
Jul 22, 2019
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
|
@mirelachirica Please review. |
Running netsocket DNS tests revealed some problems with this approach, one being the handling of multiple asynchronous DNS requests. Ari is investigating or reconsidering the solution. |
kivaisan
reviewed
Jul 29, 2019
features/cellular/framework/targets/QUECTEL/BG96/QUECTEL_BG96_CellularStack.cpp
Show resolved
Hide resolved
features/cellular/framework/targets/QUECTEL/BG96/QUECTEL_BG96_CellularStack.cpp
Show resolved
Hide resolved
AriParkkila
force-pushed
the
cell-bg96-dns
branch
from
2da5679 to
db03078
Compare
|
@mirelachirica @kivaisan please re-review. |
kivaisan
reviewed
Jul 31, 2019
AriParkkila
force-pushed
the
cell-bg96-dns
branch
from
db03078 to
71c7ed2
Compare
features/cellular/framework/targets/QUECTEL/BG96/QUECTEL_BG96_CellularStack.cpp
Show resolved
Hide resolved
features/cellular/framework/targets/QUECTEL/BG96/QUECTEL_BG96_CellularStack.cpp
Show resolved
Hide resolved
kivaisan
approved these changes
Jul 31, 2019
mirelachirica
approved these changes
Aug 1, 2019
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
SeppoTakalo
added
ready for merge
release-version: 5.14.0-rc1
and removed
needs: CI
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cellular modem BG96 AT driver added with DNS support.
Pull request type
Reviewers
@mirelachirica
Release Notes