-
Notifications
You must be signed in to change notification settings - Fork 3k
Update EP_AGORA target pinout #11099
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@trowbridgec, thank you for your changes. |
@trowbridgec Please clean up your Git history. It contains merge commit and therefore looks like it contains more changes than your commits. Remove the merge commit, rebase your changes on top of master, and force-push the branch again. |
289d55a
to
35932a3
Compare
35932a3
to
04ca01d
Compare
@SeppoTakalo Sorry about that...should be good to go now. |
@ARMmbed/team-embeddedplanet Please review. |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
@maclobdell, @deepikabhavnani, @ygoyal18 , @x85446, @jjohnson-arm , @WendyHead Please note that if compiling an application for the Agora's you have; after this PR you will need to specify via app_config.json that you have a 1.0 board revision. Feel free to exchange your 1.0 for a 1.1 via request for RMA to my email or [email protected] |
@maclobdell @SeppoTakalo LGTM |
Description
Updates the
PinNames.h
file for theEP_AGORA
target. The pinout changed in a significant way between HW rev 1.0 and 1.1. By default, we now assume HW rev 1.1, but you can force HW rev 1.0 by defining a macro namedEP_AGORA_HW_REV_1_0
(most easily from thembed_app.json
file).Pull request type
Reviewers
@maclobdell
@ARMmbed/team-embeddedplanet