Skip to content

Update EP_AGORA target pinout #11099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 5, 2019

Conversation

trowbridgec
Copy link

Description

Updates the PinNames.h file for the EP_AGORA target. The pinout changed in a significant way between HW rev 1.0 and 1.1. By default, we now assume HW rev 1.1, but you can force HW rev 1.0 by defining a macro named EP_AGORA_HW_REV_1_0 (most easily from the mbed_app.json file).

Pull request type

[ ] Fix
[ ] Refactor
[x] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@maclobdell
@ARMmbed/team-embeddedplanet

@ciarmcom ciarmcom requested review from maclobdell and a team July 23, 2019 19:00
@ciarmcom
Copy link
Member

@trowbridgec, thank you for your changes.
@maclobdell @ARMmbed/mbed-os-core @ARMmbed/mbed-os-pan @ARMmbed/mbed-os-storage @ARMmbed/mbed-os-wan @ARMmbed/mbed-os-test @ARMmbed/mbed-os-ipcore @ARMmbed/mbed-os-maintainers @ARMmbed/mbed-os-hal @ARMmbed/mbed-os-crypto please review.

@SeppoTakalo
Copy link
Contributor

@trowbridgec Please clean up your Git history. It contains merge commit and therefore looks like it contains more changes than your commits.

Remove the merge commit, rebase your changes on top of master, and force-push the branch again.
Thanks.

@trowbridgec trowbridgec force-pushed the update-ep-agora-pinout branch from 35932a3 to 04ca01d Compare July 26, 2019 15:48
@trowbridgec
Copy link
Author

@SeppoTakalo Sorry about that...should be good to go now.

@SeppoTakalo
Copy link
Contributor

@ARMmbed/team-embeddedplanet Please review.

@mbed-ci
Copy link

mbed-ci commented Jul 29, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@SeppoTakalo SeppoTakalo requested a review from a team July 29, 2019 14:45
@0Grit
Copy link

0Grit commented Jul 29, 2019

@maclobdell, @deepikabhavnani, @ygoyal18 , @x85446, @jjohnson-arm , @WendyHead

Please note that if compiling an application for the Agora's you have; after this PR you will need to specify via app_config.json that you have a 1.0 board revision.

Feel free to exchange your 1.0 for a 1.1 via request for RMA to my email or [email protected]

@0Grit
Copy link

0Grit commented Aug 1, 2019

@maclobdell @SeppoTakalo LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants