Target msp432 support #11117
Target msp432 support #11117
Conversation
|
@Terstegge, thank you for your changes. |
|
@Terstegge Please cleanup the Git branch. You have a merge commit in your history, which makes review a bit annoying. Please remove the merge commit and rebase your changes on top of master branch. It makes history look cleaner, and review looks correct. |
|
Okay - finally managed to clean up the branch by rebasing to upstream/master and manually deleting some commits... Hope the branch is okay now. |
|
Hi @Terstegge Or |
The changes were done because of name clashes. The file msp432p401r.h is the official register definition file as distributed by TI. Changes to this file are therefore not the first choice, because this file will be updated on a regular basis. In line 1353 you find the CS macro for the Clock System (CS) subsystem. Without the changes in the mbed OS code you will get compile errors. The same is true for DIR_H (line 605). |
|
I just found a way to leave CS and DIR_H as they are, so renaming is not necessary any more (see 3rd commit). |
|
I do not understand the problem in the file targets/TARGET_TI/mbed_rtx.h. |
|
Latest commit removes MPU. All 86 tests pass now without error: Logfile |
Very nice ! We are close to 5.14 code freeze, I might review this in more detail the next week. |
|
Last commit cleans up the linker script (removal of VECTORS stuff) and introduces a common startup file. |
Removed private TODO file. Fixed cmsis.h so that renaming of CS and DIR_H is not necessary any more. Leave pinmap.h unchanged although it should include stdint.h Moved stdint.h to PinNames.h instead, where it is also used. Reworked system startup (clock configuration) to be more flexible (different clock sources for MCLK and SMCLK, configurable clock dividers). Fixed Copyright headers Changed default clock settings for MSP432 Launchpad to MCLK 48 MHz (HFXT) and SMCLK 24 MHz (HFXT) Remove mbed_rtx.h Added common mbed_rtx.h file (merge with lastest master) Added support for IAR toolchain Fixed some astyle problems. Added support for ARM C5/C6 toolchains Small changes to us_ticker implementation after port testing. Changed default clock configuration to DCO (MCLK 48MHz, SMCLK 24MHz). De-configured the LFXT crysal, because this made the system_reset() test to time out. Removed MPU from device_has list. Changed clock source to HFXT. Reworked startup_msp432p401r.c -> now only one startup file for all compilers. Changed all linker scripts to delete VECTORS stuff (not needed). Moved position of MSP432 in targets.json so TI stuff is in one block.
|
CI started |
|
@MarceloSalazar Can you review as well? |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
|
Please let me know if I should do a rebase, in case the review process will take longer. CI would have to be repeated, I guess. |
|
What are the plans on ARM side for this PR? Two weeks have gone without any progress. |
|
I'll restart CI and should be good to go. |
Test run: FAILEDSummary: 1 of 11 test jobs failed Failed test jobs:
|
|
Internal CI error, will restart once we complete rc3 PR |
|
CI started |
Test run: FAILEDSummary: 1 of 11 test jobs failed Failed test jobs:
|
|
memory usage restarted |
Description
New support for MSP432 targets (specifically the MSP432 Launchpad from TI).
Most functionality (ANALOGIN, I2C, I2C_ASYNCH, I2CSLAVE, INTERRUPTIN,
PORTIN, PORTINOUT, PORTOUT, PWMOUT, SERIAL, SPI, SPI_ASYNCH,
SPISLAVE, STDIO_MESSAGES, USTICKER) is implemented.
The MSP432 Launchpad does not support the DAPLink protocol, so binaries have to
be downloaded with the DSLite tool from TI. This is also the reason why greentea
testing could not be done. But all available testcases (86) were tested manually.
Pull request type
Reviewers
Release Notes