Skip to content

Updated testcases #11130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 2, 2019
Merged

Updated testcases #11130

merged 4 commits into from
Aug 2, 2019

Conversation

Tharazi97
Copy link
Contributor

Description

Fixes #9687
Changed testcases to look like this template:

#if !CONDITION
#error [NOT_SUPPORTED] This test requires CONDITION
#else
#include "CONDITION_or_something.h"
...
testcases
...
#endif // CONDITION

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@fkjagodzinski @maciejbocianski @deepikabhavnani @jamesbeyond, @SeppoTakalo

@ciarmcom
Copy link
Member

@Tharazi97, thank you for your changes.
@maciejbocianski @jamesbeyond @fkjagodzinski @SeppoTakalo @deepikabhavnani @ARMmbed/mbed-os-crypto @ARMmbed/mbed-os-core @ARMmbed/mbed-os-wan @ARMmbed/mbed-os-pan @ARMmbed/mbed-os-storage @ARMmbed/mbed-os-hal @ARMmbed/mbed-os-test @ARMmbed/mbed-os-ipcore @ARMmbed/mbed-os-maintainers please review.

@bulislaw
Copy link
Member

Looks good, @jamesbeyond please review.

@@ -357,3 +357,4 @@ int main()
return !Harness::run(specification);
}

#endif // !DEVICE_USTICKER
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing newlines at the end of files. (Probably all of them).

Some tools or compilers complain about this.

@mbed-ci
Copy link

mbed-ci commented Jul 31, 2019

Test run: SUCCESS

Summary: 4 of 4 test jobs passed
Build number : 1
Build artifacts

Copy link
Contributor

@SeppoTakalo SeppoTakalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mbed-ci
Copy link

mbed-ci commented Aug 1, 2019

Test run: SUCCESS

Summary: 4 of 4 test jobs passed
Build number : 2
Build artifacts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not supported test floods the log file with errors
6 participants