Skip to content

Fix inclusion of test related directories by build tool #11166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 13, 2019

Conversation

hugueskamba
Copy link
Collaborator

@hugueskamba hugueskamba commented Aug 5, 2019

Description

Prevent mbed-os/components/TARGET_PSA/services/attestation/qcbor/test to be included by the build tool during compilation.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@evedon @gpsimenos

@ciarmcom ciarmcom requested review from evedon, gpsimenos and a team August 5, 2019 15:00
@ciarmcom
Copy link
Member

ciarmcom commented Aug 5, 2019

@hugueskamba, thank you for your changes.
@gpsimenos @evedon @ARMmbed/mbed-os-maintainers please review.

Copy link
Contributor

@evedon evedon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@ARMmbed/mbed-os-tools

@evedon
Copy link
Contributor

evedon commented Aug 6, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Aug 6, 2019

Test run: FAILED

Summary: 3 of 4 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-ARM
  • jenkins-ci/mbed-os-ci_build-GCC_ARM
  • jenkins-ci/mbed-os-ci_build-IAR

@mbed-ci
Copy link

mbed-ci commented Aug 6, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 2
Build artifacts

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 9, 2019

I restarted events, should be ready for merge soon

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 9, 2019

[Fatal Error] AsyncOp.h@21,19: Mutex.h: No such file or directory

@hugueskamba Please review events failures in the travis. They don't look related. I restarted it to make sure. Not certain how adding test ignore inside cbor could affect building usb files.

@hugueskamba
Copy link
Collaborator Author

hugueskamba commented Aug 9, 2019

[Fatal Error] AsyncOp.h@21,19: Mutex.h: No such file or directory

@hugueskamba Please review events failures in the travis. They don't look related. I restarted it to make sure. Not certain how adding test ignore inside cbor could affect building usb files.

@0xc0170 The failure is not related to this change.
It is happening because mbed-os/drivers/source/usb/ is included in the build but should not because for that particular build mbed-os/rtos is excluded.

@hugueskamba hugueskamba force-pushed the hk-ignore-test-dirs branch from 26673cb to e507435 Compare August 9, 2019 09:21
@hugueskamba
Copy link
Collaborator Author

hugueskamba commented Aug 9, 2019

Force pushed to rebase from master https://github.com/ARMmbed/mbed-os/compare/26673cb8b0c8dbc55b121cd24137d14ee5fe5a80..e5074356556fdb0659b8fa2185857e370311e5c8 to potentially fix the CI build issue.

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 9, 2019

CI restarted

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 9, 2019

I restarted CI. Travis seems to have a problem with hook update, I restarted it

@mbed-ci
Copy link

mbed-ci commented Aug 9, 2019

Test run: FAILED

Summary: 2 of 11 test jobs failed
Build number : 3
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_exporter
  • jenkins-ci/mbed-os-ci_greentea-test

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 12, 2019

Waiting for pr-merge fix , cc @ARMmbed/mbed-os-test

Exporters restarted

@0xc0170 0xc0170 merged commit 96fbf9d into ARMmbed:master Aug 13, 2019
@hugueskamba hugueskamba deleted the hk-ignore-test-dirs branch August 13, 2019 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants