Skip to content

Cellular: failure when deleting created context is not considered error #11190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 15, 2019
Merged

Cellular: failure when deleting created context is not considered error #11190

merged 1 commit into from
Aug 15, 2019

Conversation

jarvte
Copy link
Contributor

@jarvte jarvte commented Aug 9, 2019

Description

If context delete fails there is nothing we or application can do. There is no point
returning an error for this. This affects to CellularContext/AT_CellularContext::disconnect
not returning an error if context delete fails. No need for documentation update.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@AriParkkila

Cellular: failure when deleting created context is not considered as …
10251ab 
…an error

If delete fails there is nothing we or application can do. There is no point
returning an error for this. This affects to AT_CellularContext::disconnect
not returning an error if context delete fails.
@ciarmcom ciarmcom requested review from AriParkkila and a team August 9, 2019 11:00
@ciarmcom
Copy link
Member

ciarmcom commented Aug 9, 2019

@jarvte, thank you for your changes.
@AriParkkila @ARMmbed/mbed-os-wan @ARMmbed/mbed-os-maintainers please review.

0xc0170
0xc0170 reviewed Aug 9, 2019
View reviewed changes
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this fix for the patch release (changing the return value)?

@ciarmcom ciarmcom requested review from AriParkkila and a team August 9, 2019 13:00
@ciarmcom
Copy link
Member

ciarmcom commented Aug 9, 2019

@jarvte, thank you for your changes.
@AriParkkila @ARMmbed/mbed-os-wan @ARMmbed/mbed-os-maintainers please review.

@jarvte
Copy link
Contributor Author

jarvte commented Aug 12, 2019

Is this fix for the patch release (changing the return value)?

Not mandatory for the patch release but if this is not too big of a change it would be good to be there. This helps to get rid of the disconnect failures which we or the app can do nothing about and should be very rare.

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 12, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Aug 12, 2019

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_exporter

@jarvte
Copy link
Contributor Author

jarvte commented Aug 13, 2019

I guess exporter failure is not related to this pr.

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 13, 2019

It's not, Tracking issue for exporters failure: #11209

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 14, 2019

CI restarted

@mbed-ci
Copy link

mbed-ci commented Aug 14, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 2
Build artifacts

@adbridge adbridge merged commit 2af2b1b into ARMmbed:master Aug 15, 2019
@jarvte jarvte deleted the fix_wise1570_netsocket_tests branch August 15, 2019 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@AriParkkila AriParkkila AriParkkila approved these changes

@mirelachirica mirelachirica mirelachirica approved these changes

Assignees
No one assigned
Labels
release-version: 5.14.0-rc1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jarvte @ciarmcom @0xc0170 @mbed-ci @AriParkkila @mirelachirica @adbridge