Cellular: moved string_to_pdp_type from AT_CellularContext to Cellula… #11200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rUtil string_to_pdp_type is a common method for AT and other layers. Without moving there will be duplicate methods.
kivaisan
approved these changes
Aug 12, 2019
kivaisan
approved these changes
Aug 12, 2019
mirelachirica
approved these changes
Aug 12, 2019
0xc0170
approved these changes
Aug 12, 2019
|
CI started |
Test run: FAILEDSummary: 1 of 11 test jobs failed Failed test jobs:
|
|
Tracking issue for exporters failure: #11209 |
Test run: FAILEDSummary: 1 of 12 test jobs failed Failed test jobs:
|
Should be gone from config , can be ignored here, not valid. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
string_to_pdp_type is a common method for AT and other layers. Without moving there will be duplicate methods.
Pull request type
Reviewers
@kivaisan
Release Notes
Moved string_to_pdp_type from AT_CellularContext to CellularUtil. string_to_pdp_type is a common method for AT and other layers. Without moving there will be duplicate methods.