Cellular: Fixed improper AT handler setup through virtual calls in co… #11201
+72
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mirelachirica, thank you for your changes. |
jarvte
approved these changes
Aug 12, 2019
|
I dont see the check failure being related to the changes in this PR. |
|
Can some of the @ARMmbed/mbed-os-maintainers or @ARMmbed/mbed-os-wan review this? |
…nstructor Added AT handler setup method to be used for initialisation routines that are virtual and therefore cannot be called from constructor.
mirelachirica
force-pushed
the
bug_virtual_in_constructor
branch
from
dd9f30d to
75c823c
Compare
AnttiKauppila
approved these changes
Aug 16, 2019
0xc0170
approved these changes
Aug 19, 2019
|
CI started |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added AT handler setup method to be used for initialisation routines that are virtual and therefore cannot be called from constructor.
For now it only sets AT send delay and URCs.
Pull request type
Reviewers
@AriParkkila @jarvte