Fix TT_M3HQ build problem #11237
Merged
Fix TT_M3HQ build problem #11237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Tharazi97, thank you for your changes. |
jamesbeyond
reviewed
Aug 16, 2019
jamesbeyond
suggested changes
Aug 16, 2019
There was a problem hiding this comment.
Can we fix this issue like what Toshiba did, defind macros to cast the object
https://github.com/ARMmbed/mbed-os/blob/master/targets/TARGET_TOSHIBA/TARGET_TMPM3HQ/i2c_api.c#L24-L28
Development board TT_M3HQ doesn't have CTS/RTS on its pinout. If that is not the case PinMap_UART_RTS should be created.
Tharazi97
force-pushed
the
TT_M3HQ-build-problem
branch
from
dc86501 to
3c2ed16
Compare
0xc0170
approved these changes
Aug 19, 2019
|
CI started |
|
Hi @MarceloSalazar, could you review the PR, and tag team thundersoft to review as well |
|
@ThunderSoft123 Please review |
|
Fixes nightly, important to get in asap |
jamesbeyond
approved these changes
Aug 19, 2019
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
|
Travis job restarted |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes the problem with compiling i2c api, serial api and spi api on TT_M3HQ.
fixes: #11143
Pull request type
Reviewers
@jamesbeyond @maciejbocianski
Release Notes