Skip to content

crypto: Copy legacy crypto from Mbed Crypto #11239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 20, 2019

Conversation

Patater
Copy link
Contributor

@Patater Patater commented Aug 16, 2019

Description

Mbed TLS no longer provides legacy crypto C or H files. Obtain the files
from Mbed Crypto instead.

Pull request type

[ ] Fix
[X] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@Patater Patater mentioned this pull request Aug 16, 2019
2 tasks
The portable and correct way to include Mbed TLS header files is
"mbedtls/someheader.h". It's Mbed OS specific, unecessary, and incorrect
to use "mbedtls/inc/mbedtls/someheader.h".
Mbed TLS no longer provides legacy crypto C or H files. Obtain the files
from Mbed Crypto instead.
@Patater Patater force-pushed the import-mbedtls-crypto-from-mbedcrypto branch from 67d2894 to b6c24e2 Compare August 16, 2019 08:21
@Patater
Copy link
Contributor Author

Patater commented Aug 16, 2019

Rebased to fix lwip include of mbedtls header.

Copy link
Contributor

@yanesca yanesca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@ciarmcom ciarmcom requested review from a team August 16, 2019 09:00
@ciarmcom
Copy link
Member

@Patater, thank you for your changes.
@ARMmbed/mbed-os-tls @ARMmbed/mbed-os-crypto @ARMmbed/mbed-os-ipcore @ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 19, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Aug 19, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit 0838248 into ARMmbed:master Aug 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants