AT_CellularSMS: set "international" flag in PDU when applicable #11247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, create_pdu receives a destination address without '+' prefix, and always sets the "type of address" to "unknown". That means, the number needs to contain appropriate international number prefix (00/011) if necessary - which is not the case if the leading + is simply stripped. This changes send_sms behavior so that when a SMS is sent to an international number (indicated by leading +): - AT+CMGS command receives the number with + prefix, - created PDU has the "international" flag set.
|
@dextero, thank you for your changes. |
jarvte
approved these changes
Aug 19, 2019
0xc0170
approved these changes
Aug 19, 2019
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
|
Sitting on top of 5.14 changes so targeting that instead now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently,
create_pdureceives a destination address without '+' prefix, and always sets the "type of address" to "unknown". That means, the number needs to contain appropriate international number prefix (00/011) if necessary - which is not the case if the leading + is simply stripped.This changes
send_smsbehavior so that when a SMS is sent to an international number (indicated by leading +):The change was tested with Quectel BG96 AT modem.
Pull request type