Skip to content

MCUXpresso: Add TICKLESS support for LPC platforms #11261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 22, 2019

Conversation

mmahadevan108
Copy link
Contributor

Description

LPC platforms do not have LPTicker, this PR uses the us-ticker to enable TICKLESS support

Pull request type

[ ] Fix
[ ] Refactor
[X] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@ciarmcom ciarmcom requested a review from a team August 19, 2019 19:00
@ciarmcom
Copy link
Member

@mmahadevan108, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 20, 2019

CI started

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 20, 2019

We are having an internal issue in CI, will be fixed and this test restarted

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 21, 2019

CI restarted

@@ -1997,6 +2001,10 @@
"FLASH",
"MPU"
],
"overrides": {
"tickless-from-us-ticker": true,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That switches the deep sleep off, so the gains from tickless are not amazing.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This platform does not have an LPTICKER that matches the mbed requirements. What do you suggest?

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 21, 2019

Client test is experiencing known issue, will be fixed soon

@mbed-ci
Copy link

mbed-ci commented Aug 21, 2019

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_cloud-client-test

@adbridge
Copy link
Contributor

restarted

@mbed-ci
Copy link

mbed-ci commented Aug 21, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 3
Build artifacts

@0xc0170 0xc0170 merged commit 9d6bfcf into ARMmbed:master Aug 22, 2019
@mmahadevan108 mmahadevan108 deleted the Enable_Tickless_LPC branch August 22, 2019 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants