-
Notifications
You must be signed in to change notification settings - Fork 3k
ADC internal temperature support and EMAC header fix #11266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@0xc0170 EMAC header added and ADC fix also. |
@aqib-ublox, thank you for your changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks !
Fixes #9038 |
CI started |
Test run: FAILEDSummary: 3 of 4 test jobs failed Failed test jobs:
|
we have added fix for UBLOX_EVK_ODIN_W2 |
I don't see any new commit here, @aqib-ublox please push an update? |
I am saying we added changes for UBLOX_EVK_ODIN_W2 only. No new commit |
I see. The compilation errors are valid, can you reproduce?
|
That is not point (build only for one target), the changes need to build for all targets - all green. This PR is breaking 2 other targets. To fix, you need to define ADC_ pins added here or make it only for one target (not exposing to others). |
yes agree let me update |
@0xc0170 updated please check and seen changes working for MTB target so decided to update target pins defines |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
Description
A pin configuration for Internal temperature sensor attached to ADC1 is added. Header is added to UBLOX EMAC file.
Pull request type
Reviewers
Release Notes