Skip to content

ADC internal temperature support and EMAC header fix #11266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 26, 2019

Conversation

aqib-ublox
Copy link
Contributor

Description

A pin configuration for Internal temperature sensor attached to ADC1 is added. Header is added to UBLOX EMAC file.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

@aqib-ublox
Copy link
Contributor Author

@0xc0170 EMAC header added and ADC fix also.

@ciarmcom
Copy link
Member

@aqib-ublox, thank you for your changes.
@ARMmbed/mbed-os-ipcore @ARMmbed/mbed-os-maintainers please review.

@aqib-ublox aqib-ublox changed the title ADc internal temperature suuport and EMAC header fix ADC internal temperature support and EMAC header fix Aug 21, 2019
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 21, 2019

Fixes #9038

@adbridge
Copy link
Contributor

CI started

@mbed-ci
Copy link

mbed-ci commented Aug 22, 2019

Test run: FAILED

Summary: 3 of 4 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-ARM
  • jenkins-ci/mbed-os-ci_build-IAR
  • jenkins-ci/mbed-os-ci_build-GCC_ARM

@aqib-ublox
Copy link
Contributor Author

Test run: FAILED

Summary: 3 of 4 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

* jenkins-ci/mbed-os-ci_build-ARM

* jenkins-ci/mbed-os-ci_build-IAR

* jenkins-ci/mbed-os-ci_build-GCC_ARM

we have added fix for UBLOX_EVK_ODIN_W2

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 23, 2019

I don't see any new commit here, @aqib-ublox please push an update?

@aqib-ublox
Copy link
Contributor Author

I don't see any new commit here, @aqib-ublox please push an update?

I am saying we added changes for UBLOX_EVK_ODIN_W2 only. No new commit

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 23, 2019

I see. The compilation errors are valid, can you reproduce?

MODULE_UBLOX_ODIN_W2 is inherited for MBED_CONNECT_ODIN target. But ADC_ are defined only for one of the target, means the rest are failing. Failures look valid to me.

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 23, 2019

That is not point (build only for one target), the changes need to build for all targets - all green.

This PR is breaking 2 other targets. To fix, you need to define ADC_ pins added here or make it only for one target (not exposing to others).

@aqib-ublox
Copy link
Contributor Author

That is not point, the changes need to build for all targets. This PR is breaking 2 other targets. To fix, you need to define ADC_ pins added here or make it only for one target (not exposing to others).

yes agree let me update

@aqib-ublox
Copy link
Contributor Author

@0xc0170 updated please check and seen changes working for MTB target so decided to update target pins defines

@mbed-ci
Copy link

mbed-ci commented Aug 26, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 2
Build artifacts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants