Add ethernet support on NUCLEO_H743ZI board #11274

VVESTM · 2019-08-21T09:01:00Z

Description

This pull request adds ethernet support on STM32 H7 platform.
It is based on the STM32 emac driver. As the H7 HAL is slightly different, I have added ETH_IP_VERSION_V2 switch. This has to be included in targets.json.

Work is based on @CurryGuy job and STM32 cube examples.

Tests done with this command (on IAR, ARM and GCC_ARM toolchains) :
mbed test -t IAR -m NUCLEO_H743ZI -v -n testsnetsocket

Pull request type

[ ] Fix
[ ] Refactor
[X] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@jeromecoutant @LMESTM

jeromecoutant · 2019-08-21T09:24:46Z

targets/TARGET_STM/TARGET_STM32H7/TARGET_STM32H743xI/device/TOOLCHAIN_GCC_ARM/STM32H743xI.ld

+        *(.ethusbram) 
+
+    } >RAM_D2 AT> FLASH
+}


Maybe correct this ?

jeromecoutant · 2019-08-21T09:25:09Z

features/netsocket/emac-drivers/TARGET_STM_EMAC/stm32xx_emac.cpp

@@ -475,6 +817,8 @@ void mbed_default_mac_address(char *mac)
    uint32_t word0 = *(uint32_t *)0x1FFF7A10;
 #elif defined (TARGET_STM32F7)
    uint32_t word0 = *(uint32_t *)0x1FF0F420;
+#elif defined (TARGET_STM32H7)
+    uint32_t word0 = *(uint32_t *)0x1FF0F420;


Value to check

Replaced with correct value (0x1FF1E800)

This port is based on : * CurryGuy ethernet branch : https://github.com/CurryGuy/mbed-os/tree/feature-stm32h7-emac * STM32 Cube example : Applications/LwIP/LwIP_HTTP_Server_Netconn_RTOS example Signed-off-by: Vincent Veron <[email protected]>

…am_heap Signed-off-by: Vincent Veron <[email protected]>

Signed-off-by: Vincent Veron <[email protected]>

0xc0170 · 2019-08-21T09:43:21Z

targets/targets.json

@@ -3221,9 +3222,13 @@
        "macros_add": [
            "STM32H743xx",
            "EXTRA_IDLE_STACK_REQUIRED",
-            "MBED_TICKLESS"
+            "MBED_TICKLESS",
+            "ETH_IP_VERSION_V2"


cant find this used anywhere in this PR?

This is used in features/netsocket/emac-drivers/TARGET_STM_EMAC/stm32xx_emac.cpp file. Used to differentiate H7 specific parts.

Because github doesn't expand all files by default :-)

I've missed that file ! I can see now. Wouldn't the config be better for this or ?

You prefer to add this compilation switch in an other file ? Which one do you have in mind ? (features\netsocket\emac-drivers\TARGET_STM_EMAC\mbed_lib.json for example ?)

I need this switch to be activated for only H7 platform for now. Then, if this new hal is deployed on other platform, we will need to activate it also for those new platforms.

This location seems correct to me - the target descriptor passing information to its drivers about which mode to select. (As long as the option is describing something concrete about the target, that is conceptually not locked to any particular driver implementation - so we mean this target has "V2 hardware" or "V2 HAL").

you may move the stm32xx_emac_config.h file to the family specific folder and add this option there. this way you could tune the IP version per family (and later the thread stack size if needed)

Code updated with @LMESTM solution. Effectively, user is not supposed to change this setting so the .json file can be misunderstanding.
Thanks all for comments and propositions !

ciarmcom · 2019-08-21T11:00:41Z

@VVESTM, thank you for your changes.
@ARMmbed/mbed-os-ipcore @ARMmbed/mbed-os-maintainers please review.

jeromecoutant · 2019-08-21T11:09:24Z

@ARMmbed/team-st-mcd @MarceloSalazar @facchinm

This allows to specify which hal version to use for each family. It can also be used to modify the thread stack size. Signed-off-by: Vincent Veron <[email protected]>

0xc0170 · 2019-08-21T13:40:04Z

CI started

makes UDPSOCKET_ECHOTEST_BURST_NONBLOCK and UDPSOCKET_ECHOTEST_BURST failed. In the trace, we see only UDPSOCKET_ECHOTEST_BURST_NONBLOCK failed. For UDPSOCKET_ECHOTEST_BURST, we have : Packets sent: 22, packets received 0, loss ratio 1.00 >>> 'UDPSOCKET_ECHOTEST': 1 passed, 0 failed Reproduced on NUCLEO_H743ZI (with PR ARMmbed#11274) and also with K64F board : mbed test -t IAR -m K64F -v -n tests*netsocket*udp* Signed-off-by: Vincent Veron <[email protected]>

adbridge · 2019-08-21T15:16:07Z

restarted

mbed-ci · 2019-08-21T20:40:27Z

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 2
Build artifacts

jeromecoutant approved these changes Aug 21, 2019

View reviewed changes

0xc0170 added needs: work release-version: 5.13.4 labels Aug 21, 2019

VVESTM added 3 commits August 21, 2019 11:40

Add EMAC support for NUCLEO_H743ZI

9f2e9aa

This port is based on : * CurryGuy ethernet branch : https://github.com/CurryGuy/mbed-os/tree/feature-stm32h7-emac * STM32 Cube example : Applications/LwIP/LwIP_HTTP_Server_Netconn_RTOS example Signed-off-by: Vincent Veron <[email protected]>

STM32H7 : update linker script files to use right location for lwip_r…

76fb4d2

…am_heap Signed-off-by: Vincent Veron <[email protected]>

lwip: STM32H7: specify heap location

93b8164

Signed-off-by: Vincent Veron <[email protected]>

VVESTM force-pushed the vve_eth_h7 branch from bbd5879 to 93b8164 Compare August 21, 2019 09:42

0xc0170 reviewed Aug 21, 2019

View reviewed changes

ciarmcom requested review from a team August 21, 2019 11:00

ciarmcom added the needs: review label Aug 21, 2019

michalpasztamobica mentioned this pull request Aug 21, 2019

Test result is not always reliable (TEST_ASSERT_DOUBLE_WITHIN after a failed test) #10941

Closed

Move stm32xx_emac_config.h to family specific folder

8ab6aec

This allows to specify which hal version to use for each family. It can also be used to modify the thread stack size. Signed-off-by: Vincent Veron <[email protected]>

jeromecoutant approved these changes Aug 21, 2019

View reviewed changes

0xc0170 approved these changes Aug 21, 2019

View reviewed changes

0xc0170 added needs: CI and removed needs: review needs: work labels Aug 21, 2019

LMESTM approved these changes Aug 21, 2019

View reviewed changes

0xc0170 added ready for merge and removed needs: CI labels Aug 22, 2019

0xc0170 merged commit d0c917c into ARMmbed:master Aug 22, 2019

0xc0170 removed the ready for merge label Aug 22, 2019

VVESTM mentioned this pull request Aug 23, 2019

Move RAM partition with ARM compiler #11313

Closed

VVESTM mentioned this pull request Sep 5, 2019

STM32H743 : tests-mbed_platform-crash_reporting test failing #11422

Closed

VVESTM mentioned this pull request Sep 18, 2019

STM32H7: split RAM usage #11507

Closed

Add ethernet support on NUCLEO_H743ZI board #11274

Add ethernet support on NUCLEO_H743ZI board #11274

Uh oh!

Conversation

VVESTM commented Aug 21, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Pull request type

Reviewers

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kjbracey Aug 21, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ciarmcom commented Aug 21, 2019

Uh oh!

jeromecoutant commented Aug 21, 2019

Uh oh!

0xc0170 commented Aug 21, 2019

Uh oh!

adbridge commented Aug 21, 2019

Uh oh!

mbed-ci commented Aug 21, 2019

Uh oh!

Uh oh!

VVESTM commented Aug 21, 2019 •

edited

Loading

kjbracey Aug 21, 2019 •

edited

Loading