Cordio LPA for Cypress targets #11327
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kyle-cypress, thank you for your changes. |
0xc0170
requested changes
Aug 26, 2019
| * | ||
| ******************************************************************************** | ||
| * \copyright | ||
| * Copyright 2019-2020, Cypress Semiconductor Corporation. All rights reserved. |
There was a problem hiding this comment.
Can you align the license as other files from PSOC6 ? This is not a license we can accept.
Allow more flexibile configuration for BLE radio pins
Migrate to using ThisThread::sleep_for instead.
kyle-cypress
force-pushed
the
pr/cordio-lpa
branch
from
ccae106 to
200902a
Compare
0xc0170
approved these changes
Aug 27, 2019
| } | ||
|
|
||
| void CyH4TransportDriver::initialize() | ||
| { | ||
| #if (defined(MBED_TICKLESS) && DEVICE_SLEEP && DEVICE_LPTICKER) |
There was a problem hiding this comment.
Doesn't MBED_TICKLESS contain sleep at least ?
There was a problem hiding this comment.
While https://os.mbed.com/docs/mbed-os/v5.13/porting/tickless.html states that target should support Sleep HAL API to enable TICKLESS, MBED has no checks that we can find to ensure that DEVICE_SLEEP is set if MBED_TICKLESS is set (i.e. there does not seem to be a technical means by which one implies the other). Therefore, the current implementation is cautious.
Fixes are for CY8CKIT_062S2_43012 and CY8CPROTO_062_4343W
Merged
|
Integrated via #11367 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improve Cordio Low Power Assist.
Minor fixes/enhancements to driver
This PR is dependent on #11323 and #11324
Pull request type
Reviewers
@ARMmbed/team-cypress
Release Notes