Skip to content

RTL8195AM - resuscitate AMEBA GCC/ARMCC support #11330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Sep 4, 2019

Conversation

tung7970
Copy link
Contributor

Description

Resuscitate AMEBA GCC/ARMCC support. Added USTICKER flag, cleaned up GCC linker script, and fixed several compiler warnings.

Pull request type

[ ] Fix
[ ] Refactor
[X] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

Resuscitate AMEBA GCC/ARMCC support.

@ciarmcom ciarmcom requested a review from a team August 26, 2019 05:00
@ciarmcom
Copy link
Member

@tung7970, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

],
"public": false,
"supported_toolchains": ["GCC_ARM", "ARM"],
"post_binary_hook": {
"function": "RTL8195ACode.binary_hook",
"toolchains": ["ARM_STD", "GCC_ARM", "IAR"]
"toolchains": ["ARM_STD", "GCC_ARM"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IAR should be also enabled to have "5" in the versions below.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit "disable IAR" without having a reason is not sufficient - please add more details there.

Copy link
Contributor Author

@tung7970 tung7970 Aug 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is to bring back basic RTL8195AM support, at least for GCC and ARMCC. IAR will have to be disabled until its HAL library is upgraded to IAR8.

See issue #11232

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Understood, therefore 5 version should be still disabled (not being added in this PR).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will remove that patch, and add details to disable IAR patch. But, users will have to manually add 5 to the release version to enable RTL8195AM support.

Disable IAR support until HAL library is upgraded to IAR8

Signed-off-by: Tony Wu <[email protected]>
osdep_service.c@214,61: suggest braces around empty body in an 'else' statement [-Wempty-body]

Signed-off-by: Tony Wu <[email protected]>
[Warning] tcm_heap.c@70,18: format '%x' expects argument of type 'unsigned int', but argument 2 has type 'MemChunk * {aka struct _MemChunk *}' [-Wformat=]
[Warning] tcm_heap.c@70,28: format '%x' expects argument of type 'unsigned int', but argument 3 has type 'MemChunk * {aka struct _MemChunk *}' [-Wformat=]

Signed-off-by: Tony Wu <[email protected]>
@adbridge
Copy link
Contributor

ci started

@mbed-ci
Copy link

mbed-ci commented Aug 29, 2019

Test run: FAILED

Summary: 1 of 4 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-IAR

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 30, 2019

Known internal CI issue, will restart CI later

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 30, 2019

CI restarted

@mbed-ci
Copy link

mbed-ci commented Aug 30, 2019

Test run: FAILED

Summary: 1 of 4 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-ARM

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 2, 2019

Failures are CI related, will be restarted

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 2, 2019

CI restarted

@mbed-ci
Copy link

mbed-ci commented Sep 2, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 3
Build artifacts

@0xc0170 0xc0170 merged commit 9a1ffdd into ARMmbed:master Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants