-
Notifications
You must be signed in to change notification settings - Fork 3k
RTL8195AM - resuscitate AMEBA GCC/ARMCC support #11330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@tung7970, thank you for your changes. |
], | ||
"public": false, | ||
"supported_toolchains": ["GCC_ARM", "ARM"], | ||
"post_binary_hook": { | ||
"function": "RTL8195ACode.binary_hook", | ||
"toolchains": ["ARM_STD", "GCC_ARM", "IAR"] | ||
"toolchains": ["ARM_STD", "GCC_ARM"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IAR should be also enabled to have "5" in the versions below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The commit "disable IAR" without having a reason is not sufficient - please add more details there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is to bring back basic RTL8195AM support, at least for GCC and ARMCC. IAR will have to be disabled until its HAL library is upgraded to IAR8.
See issue #11232
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Understood, therefore 5 version should be still disabled (not being added in this PR).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will remove that patch, and add details to disable IAR patch. But, users will have to manually add 5 to the release version to enable RTL8195AM support.
Signed-off-by: Tony Wu <[email protected]>
Disable IAR support until HAL library is upgraded to IAR8 Signed-off-by: Tony Wu <[email protected]>
Signed-off-by: Tony Wu <[email protected]>
osdep_service.c@214,61: suggest braces around empty body in an 'else' statement [-Wempty-body] Signed-off-by: Tony Wu <[email protected]>
[Warning] tcm_heap.c@70,18: format '%x' expects argument of type 'unsigned int', but argument 2 has type 'MemChunk * {aka struct _MemChunk *}' [-Wformat=] [Warning] tcm_heap.c@70,28: format '%x' expects argument of type 'unsigned int', but argument 3 has type 'MemChunk * {aka struct _MemChunk *}' [-Wformat=] Signed-off-by: Tony Wu <[email protected]>
Signed-off-by: Tony Wu <[email protected]>
Signed-off-by: Tony Wu <[email protected]>
ci started |
Test run: FAILEDSummary: 1 of 4 test jobs failed Failed test jobs:
|
Known internal CI issue, will restart CI later |
CI restarted |
Test run: FAILEDSummary: 1 of 4 test jobs failed Failed test jobs:
|
Failures are CI related, will be restarted |
CI restarted |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
Description
Resuscitate AMEBA GCC/ARMCC support. Added USTICKER flag, cleaned up GCC linker script, and fixed several compiler warnings.
Pull request type
Reviewers
Release Notes
Resuscitate AMEBA GCC/ARMCC support.