Updating SDP-K1 PinNames.h. #11337
Merged
Updating SDP-K1 PinNames.h. #11337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@malavikasajikumar, thank you for your changes. |
0xc0170
requested changes
Aug 27, 2019
| LED_RED = LED1, | ||
| LED_ORANGE = LED2, | ||
| LED_GREEN = LED3, | ||
|
|
There was a problem hiding this comment.
Can you remove pls dead spaces?
There was a problem hiding this comment.
One more, the commit msg should contain details from the comment here, please add why you are updating the file.
Could be:
SDP-K1: Updating pin names
Removing LED pin definitions based on color.
Removing and updating incorrect USB pin definitions.
Adding comments for Arduino SPI and I2C pins.
- Removing LED pin definitions based on color. - Removing and updating incorrect USB pin definitions. - Adding comments for Arduino SPI and I2C pins.
|
Thank you for the reviews. Fixed them here: malavikasajikumar@db0d3d2 Also, replaced a few tabs in the comments with spaces. |
0xc0170
approved these changes
Aug 28, 2019
|
This PR is part of rollup PR #11366 Please do not update this PR, or if needed, let us know asap |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Pull request type
Reviewers
@maclobdell @0xc0170
Release Notes