ESP8266: Support power pin in custom wiring #11343
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ccli8, thank you for your changes. |
kjbracey
reviewed
Aug 27, 2019
| @@ -78,7 +78,7 @@ class ESP8266Interface : public NetworkStack, public WiFiInterface { | |||
| * @param rx RX pin | |||
| * @param debug Enable debugging | |||
| */ | |||
| ESP8266Interface(PinName tx, PinName rx, bool debug = false, PinName rts = NC, PinName cts = NC, PinName rst = NC); | |||
| ESP8266Interface(PinName tx, PinName rx, bool debug = false, PinName rts = NC, PinName cts = NC, PinName rst = NC, PinName pwr = NC); | |||
There was a problem hiding this comment.
This is a binary compatibility break, but I guess this isn't a core enough component for that to be an issue.
| "value": 0 | ||
| }, | ||
| "power-on-time-ms": { | ||
| "help": "Power-on time in ms for the modem", |
There was a problem hiding this comment.
Clarify this to delay after powering on modem.
michalpasztamobica
approved these changes
Aug 27, 2019
In custom wiring, there can be a power pin to power on/off the modem. This commit supports it and allows for the following configurations: - power pin name - power pin polarity - power on/off delay time
ccli8
force-pushed
the
nuvoton_esp8266_power_pin
branch
from
c3bec41 to
650e2e5
Compare
kjbracey
approved these changes
Aug 27, 2019
|
CI started |
Test run: FAILEDSummary: 2 of 4 test jobs failed Failed test jobs:
|
|
CI restarted (internal timeout fault) |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR tries to support power pin in custom wiring for the ESP8266 module. It allows for the following configurations:
Related PR
Replacement for #11299 and #11331
Pull request type
Reviewers
@michalpasztamobica @kjbracey-arm
Release Notes