-
Notifications
You must be signed in to change notification settings - Fork 3k
Initial support for Serial Flash on PSoC Devices #11355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@kyle-cypress, thank you for your changes. |
#if defined(CYBSP_ENABLE_FLASH_STORAGE) | ||
/* The linker script allows storing data in external memory, if needed, enable access to that memory. */ | ||
cybsp_serial_flash_init(); | ||
cybsp_serial_flash_enable_xip(true); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isn't XIP enabled via separate PR (@linlingao created earlier)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, there is another PR on this. This one fixes a couple of other issues, supports multiple targets and all 3 toolchains. The other was focused on the CY8CKIT__062_4343W and GCC.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The other PR is: #11006
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@morser499 I added a generic mbed config called MBED_CONF_TARGET_XIP_ENABLE so that we can use the same config for non-cypress targets. Does CYBSP_ENABLE_FLASH_STORAGE replace MBED_CONF_TARGET_XIP_ENABLE?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think they are intended for the same thing. I think we should use your more generic macro.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@morser499 Good, I'll override it in #11006 when I rebase.
a16e465
to
d373cab
Compare
CI started |
CI aborted, will restart after another job |
Test run: FAILEDSummary: 4 of 4 test jobs failed Failed test jobs:
|
CI started |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
Description
Initial work to support serial flash on PSoC devices. Not exposed by any current targets.
This depends on #11324 and #11323
Pull request type
Reviewers
@ARMmbed/team-cypress
Release Notes