Skip to content

Initial support for Serial Flash on PSoC Devices #11355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 30, 2019

Conversation

kyle-cypress
Copy link

Description

Initial work to support serial flash on PSoC devices. Not exposed by any current targets.
This depends on #11324 and #11323

Pull request type

[ ] Fix
[ ] Refactor
[x] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@ARMmbed/team-cypress

Release Notes

@ciarmcom ciarmcom requested review from maclobdell and a team August 28, 2019 01:00
@ciarmcom
Copy link
Member

@kyle-cypress, thank you for your changes.
@maclobdell @ARMmbed/mbed-os-maintainers please review.

#if defined(CYBSP_ENABLE_FLASH_STORAGE)
/* The linker script allows storing data in external memory, if needed, enable access to that memory. */
cybsp_serial_flash_init();
cybsp_serial_flash_enable_xip(true);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't XIP enabled via separate PR (@linlingao created earlier)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, there is another PR on this. This one fixes a couple of other issues, supports multiple targets and all 3 toolchains. The other was focused on the CY8CKIT__062_4343W and GCC.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The other PR is: #11006

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@morser499 I added a generic mbed config called MBED_CONF_TARGET_XIP_ENABLE so that we can use the same config for non-cypress targets. Does CYBSP_ENABLE_FLASH_STORAGE replace MBED_CONF_TARGET_XIP_ENABLE?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think they are intended for the same thing. I think we should use your more generic macro.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@morser499 Good, I'll override it in #11006 when I rebase.

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 30, 2019

CI started

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 30, 2019

CI aborted, will restart after another job

@mbed-ci
Copy link

mbed-ci commented Aug 30, 2019

Test run: FAILED

Summary: 4 of 4 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-IAR
  • jenkins-ci/mbed-os-ci_unittests
  • jenkins-ci/mbed-os-ci_build-GCC_ARM
  • jenkins-ci/mbed-os-ci_build-ARM

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 30, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Aug 30, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 3
Build artifacts

@0xc0170 0xc0170 merged commit 335f3ad into ARMmbed:master Aug 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants