Change LSI_VALUE in STM implementation. #11383
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wrong LSI value might be causing problems witch watchdogs.
ciarmcom
requested review from
fkjagodzinski,
jamesbeyond,
maciejbocianski and
a team
|
@Tharazi97, thank you for your changes. |
jeromecoutant
approved these changes
Aug 30, 2019
|
ST_INTERNAL_REF 71438 |
0xc0170
approved these changes
Sep 2, 2019
fkjagodzinski
approved these changes
Sep 2, 2019
|
CI started |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
0xc0170
added
ready for merge
release-version: 5.14.1
and removed
needs: CI
ready for merge
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrong LSI value might be causing problems witch watchdogs. NUCLEO_F303RE failed watchdog simple reset test on nightly CI. Looking into STM drivers I have found that LSI_VALUE is defined in
https://github.com/ARMmbed/mbed-os/blob/master/targets/TARGET_STM/TARGET_STM32F3/device/stm32f3xx_hal_conf.h
and in
https://github.com/ARMmbed/mbed-os/blob/master/targets/TARGET_STM/TARGET_STM32F3/device/stm32f3xx_ll_rcc.h
with different values (in first with 40 kHZ and in second with 32kHz). Is it intetional? I think that may be causing the problems. Fail is hard to reproduce because of high variance in LSI frequency on these boards.
Description
Pull request type
Reviewers
@jamesbeyond @LMESTM @maciejbocianski @fkjagodzinski
Release Notes