Skip to content

Return proper error if internal storage configuration not given #11390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

Return proper error if internal storage configuration not given #11390

wants to merge 5 commits into from

Conversation

SeppoTakalo
Copy link
Contributor

Description

If function _storage_config_TDB_INTERNAL() is called, but
proper configuration for TDBStore location in flash is not
given, return MBED_ERROR_UNSUPPORTED instead of dummy, that
does not work.

This fixes KVStore related nightly tests on LPC55S69_NS

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@VeijoPesonen

Release Notes

@SeppoTakalo
Copy link
Contributor Author

@0xc0170 Why there is no labels in this PR? Looks like the Bot have not touched this at all.

Add Needs: CI as this is now reviewed and approved.

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 3, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Sep 3, 2019

Test run: FAILED

Summary: 1 of 4 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-GCC_ARM

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 3, 2019

CI restarted, internal fault

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 3, 2019

Because of 5.14.0-rc1 CI jobs, we aborted CI job here. We will restart once 5.14.0rc1 is ready.

@mbed-ci
Copy link

mbed-ci commented Sep 3, 2019

Test run: FAILED

Summary: 3 of 4 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-ARM
  • jenkins-ci/mbed-os-ci_build-GCC_ARM
  • jenkins-ci/mbed-os-ci_build-IAR

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 4, 2019

CI restarted

@mbed-ci
Copy link

mbed-ci commented Sep 4, 2019

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 3
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 4, 2019

are failures related:

| NUCLEO_F411RE-ARMC6 | NUCLEO_F411RE | features-device_key-tests-device_key-functionality          | Device Key - derived key consistency 16 byte key                    | 0      | 0      | SKIPPED | 0.0                |
| NUCLEO_F411RE-ARMC6 | NUCLEO_F411RE | features-device_key-tests-device_key-functionality          | Device Key - derived key consistency 32 byte key                    | 0      | 0      | SKIPPED | 0.0                |
| NUCLEO_F411RE-ARMC6 | NUCLEO_F411RE | features-device_key-tests-device_key-functionality          | Device Key - derived key key type 16                                | 0      | 0      | SKIPPED | 0.0                |
| NUCLEO_F411RE-ARMC6 | NUCLEO_F411RE | features-device_key-tests-device_key-functionality          | Device Key - derived key key type 32                                | 0      | 0      | SKIPPED | 0.0                |
| NUCLEO_F411RE-ARMC6 | NUCLEO_F411RE | features-device_key-tests-device_key-functionality          | Device Key - derived key wrong key type                             | 0      | 0      | SKIPPED | 0.0                |
| NUCLEO_F411RE-ARMC6 | NUCLEO_F411RE | features-device_key-tests-device_key-functionality          | Device Key - inject value 16 byte size                              | 0      | 0      | SKIPPED | 0.0                |
| NUCLEO_F411RE-ARMC6 | NUCLEO_F411RE | features-device_key-tests-device_key-functionality          | Device Key - inject value 32 byte size                              | 0      | 0      | SKIPPED | 0.0                |
| NUCLEO_F411RE-ARMC6 | NUCLEO_F411RE | features-device_key-tests-device_key-functionality          | Device Key - inject value several times                             | 0      | 0      | SKIPPED | 0.0                |
| NUCLEO_F411RE-ARMC6 | NUCLEO_F411RE | features-device_key-tests-device_key-functionality          | Device Key - inject value wrong size                                | 0      | 0      | SKIPPED | 0.0                |
| NUCLEO_F411RE-ARMC6 | NUCLEO_F411RE | features-device_key-tests-device_key-functionality          | Device Key - long consistency test                                  | 0      | 0      | ERRO

?

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 6, 2019

@SeppoTakalo Please review test failures

@SeppoTakalo
Copy link
Contributor Author 

NUCLEO_F429ZI-GCC_ARM | NUCLEO_F429ZI | components-target_psa-tests-compliance_attestation-test_a001 | FAIL

Now I need to study why F429ZI fails PSA test, or why it even builds PSA component.

@mbed-ci
Copy link

mbed-ci commented Sep 11, 2019

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 4
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 11, 2019

CI restarted

@SeppoTakalo
Copy link
Contributor Author

After studying, I have now concluded that PSA and Crypto tests fail because they expect storage to be configured, but it is not.

For example, PSA requires (I'm assuming) secure storage in the internal flash, but for F429ZI there is not configuration given, so it does not work.
Previously, the API was passing some dummy value, which probably was OK for testing, but not OK for any real environment.

We have only 3 boards, that have required TDBStore values defined: https://github.com/ARMmbed/mbed-os/blob/master/features/storage/kvstore/conf/tdb_internal/mbed_lib.json

I'm assuming that only those can now run those PSA and crypto tests that require secure storage.

@mbed-ci
Copy link

mbed-ci commented Sep 11, 2019

Test run: FAILED

Summary: 3 of 4 test jobs failed
Build number : 5
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-GCC_ARM
  • jenkins-ci/mbed-os-ci_build-IAR
  • jenkins-ci/mbed-os-ci_build-ARM

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 17, 2019

I see this was updated, should be ready for CI?

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 18, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Sep 18, 2019

Test run: FAILED

Summary: 3 of 4 test jobs failed
Build number : 6
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-ARM
  • jenkins-ci/mbed-os-ci_build-IAR
  • jenkins-ci/mbed-os-ci_build-GCC_ARM

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 18, 2019

Failures look still related

@0xc0170 0xc0170 removed the needs: CI label Sep 18, 2019
@SeppoTakalo
Copy link
Contributor Author

@alzix Why PSA flag was enabled on all Pelion boards on: 7d25dcc

#9195

Should that be reverted, or...how to proceed?

@SeppoTakalo
Copy link
Contributor Author

I'll try with that commit reverted, whether it works now or not.

@mbed-ci
Copy link

mbed-ci commented Sep 27, 2019

Test run: FAILED

Summary: 3 of 4 test jobs failed
Build number : 7
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-ARM
  • jenkins-ci/mbed-os-ci_build-GCC_ARM
  • jenkins-ci/mbed-os-ci_build-IAR

@mbed-ci
Copy link

mbed-ci commented Sep 27, 2019

Test run: FAILED

Summary: 1 of 4 test jobs failed
Build number : 8
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_unittests

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 30, 2019

jenkins-ci/mbed-os-ci_unittests

Restarted, should be fixed in CI

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 30, 2019

I restarted entire pipeline

@mbed-ci
Copy link

mbed-ci commented Sep 30, 2019

Test run: FAILED

Summary: 3 of 4 test jobs failed
Build number : 9
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-ARM
  • jenkins-ci/mbed-os-ci_build-IAR
  • jenkins-ci/mbed-os-ci_build-GCC_ARM

@mbed-ci
Copy link

mbed-ci commented Oct 1, 2019

Test run: FAILED

Summary: 3 of 4 test jobs failed
Build number : 10
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-IAR
  • jenkins-ci/mbed-os-ci_build-ARM
  • jenkins-ci/mbed-os-ci_build-GCC_ARM

@adbridge
Copy link
Contributor

Not sure why this is failing, retrying CI one more time

@mbed-ci
Copy link

mbed-ci commented Oct 11, 2019

Test run: FAILED

Summary: 2 of 11 test jobs failed
Build number : 11
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_cloud-client-test
  • jenkins-ci/mbed-os-ci_greentea-test

@adbridge
Copy link
Contributor

Mmmm now failed in a different way, restarting ci yet again

@mbed-ci
Copy link

mbed-ci commented Oct 11, 2019

Test run: FAILED

Summary: 2 of 11 test jobs failed
Build number : 12
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_cloud-client-test
  • jenkins-ci/mbed-os-ci_greentea-test

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 14, 2019

@SeppoTakalo Please review failures. cloud client test look related.

@SeppoTakalo
Copy link
Contributor Author

Don't push this into CI.

This needs a bit more thinking as the approach does not seem to be correct. It looks like assumption is that KVStore should work, even when not configured to any location.

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 14, 2019 •
edited
Loading

Don't push this into CI.

I added needs work and I also remove now 5.14.1 (will be in the next patch release the earliest).

@jenia81
Copy link

jenia81 commented Oct 15, 2019

I believe this a breaking change for PDMC.
Removing PSA label from K66F, NUCLEO_F429ZI and UBLOX_EVK_ODIN_W2 targets will cause failure in entropy injection flow for those targets.
cc: @teetak01 @yogpan01

@0xc0170 0xc0170 self-requested a review October 18, 2019 12:20
@SeppoTakalo SeppoTakalo deleted the IOTSTOR-925 branch December 10, 2019 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VeijoPesonen VeijoPesonen VeijoPesonen approved these changes

@0xc0170 0xc0170 Awaiting requested review from 0xc0170

Assignees
No one assigned
Labels
needs: work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@SeppoTakalo @0xc0170 @mbed-ci @Patater @adbridge @jenia81 @VeijoPesonen