Skip to content

Cypress Cordio Driver Update #11518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 30, 2019
Merged

Cypress Cordio Driver Update #11518

merged 3 commits into from
Sep 30, 2019

Conversation

MukundGitHub
Copy link
Contributor

@MukundGitHub MukundGitHub commented Sep 18, 2019

Description

This change applies to only to the HCI driver for Cypress WiFi+BT (4343W and 43012) combo chipsets.

The Cypress Specific HCI Cordio Driver has been updated to add:

  1. MCU and BT device low-power support
  2. HCI UART enhanced to work at 3M baud rate for improved BT performance. In order to put the UART interface at 3M baud rate the state machine for initialization has been modified
  3. Updated BT device-wake pin drive mode from input to output mode to be able wake up the BT device from low-power state when needed
  4. Added delays to BT device wake de-assert function to ensure that UART data is drained

These changes are inter-connected and hence being merged together.
Test: mbed-os-example-ble-LED application and mbed-os-example-ble-Beacon application have been tested with the changes. The applications run as expected.

Pull request type

[ ] Fix
[ ] Refactor
[ x] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

@ciarmcom ciarmcom requested review from a team September 18, 2019 23:00
@ciarmcom
Copy link
Member

@MukundGitHub, thank you for your changes.
@ARMmbed/mbed-os-pan @ARMmbed/mbed-os-maintainers please review.

Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cypress Cordio Driver Update - please extend the commit msg

What update is this about. I see Pull output change here, handling sleep, adding delay to deassert and update baudrate

Looks like multiple things changed in one commit.

@MukundGitHub
Copy link
Contributor Author

Updated the Merge comment as requested. The changes are inter-connected - with enabling of 3M baud and logic for enabling Cypress BT Chip to enter Low Power state. The MCU Device Wake Pin is configured properly and some delays added when de-asserting the Device Wake Pin to BT Chip.

@MukundGitHub
Copy link
Contributor Author

Added capability to have BT Cordio stack working on Cypress BT chips without BT Device Wake and Host Wake Pins configured.
The changes are inter-related and hence being combined in single MR.

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 24, 2019

@MukundGitHub Can you add this to the first commit:

Updated the Merge comment as requested. The changes are inter-connected - with enabling of 3M baud and logic for enabling Cypress BT Chip to enter Low Power state. The MCU Device Wake Pin is configured properly and some delays added when de-asserting the Device Wake Pin to BT Chip.

It would be nice to have there some background. Otherwise it looks good to me!

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 26, 2019

I don't see the requested change in the commit message, please let us know once done

@MukundGitHub
Copy link
Contributor Author

Updated the Description with details. Please accept the PR and Merge the changes.

@0xc0170 0xc0170 self-requested a review September 30, 2019 11:19
@0xc0170
Copy link
Contributor

0xc0170 commented Sep 30, 2019

CI started

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 30, 2019

Note to myself: include description in the merge commit when integrating

@mbed-ci
Copy link

mbed-ci commented Sep 30, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants