Cellular: Fix resolving of DNS server IPv4/6 address #11548
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AriParkkila, thank you for your changes. |
| @@ -1065,3 +1065,16 @@ void AT_CellularContext::set_disconnect() | |||
| _is_connected = false; | |||
| _device->cellular_callback(NSAPI_EVENT_CONNECTION_STATUS_CHANGE, NSAPI_STATUS_DISCONNECTED, this); | |||
| } | |||
|
|
|||
| void AT_CellularContext::is_prefer_ipv6(char *ip, size_t ip_size, char *ip2, size_t ip2_size) | |||
There was a problem hiding this comment.
This wouldnt be needed if CGCONTRDP's local address is checked, instead of quering the info from the stack.
There was a problem hiding this comment.
@mirelachirica please re-review
AriParkkila
force-pushed
the
cell-dns-ip
branch
from
87f5a4a to
c2b5966
Compare
AriParkkila
force-pushed
the
cell-dns-ip
branch
from
c2b5966 to
8054b8e
Compare
mirelachirica
approved these changes
Sep 25, 2019
0xc0170
approved these changes
Oct 1, 2019
|
CI started |
|
Restarting CI |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix resolving of DNS server IPv4/6 address, if a network returns just IPv4 local address but both IPv4 and IPv6 addresses for DNS.
Pull request type
Reviewers
@mirelachirica
Release Notes