Skip to content

Coverity fixes #11558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 7, 2019
Merged

Coverity fixes #11558

merged 4 commits into from
Oct 7, 2019

Conversation

Tharazi97
Copy link
Contributor

Description

Fixes some minor Coverity warnings.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

@Tharazi97
CellularUtil prefer_ipv6: check length.
7c13b8f 
Fixes Coverity issue about not checking the length of string before copying it.
@Tharazi97
CellularStack: remove unnecessary assignment.
b0b9553 
Fixes Coverity issue about unused variable.
@Tharazi97
sn_coap_builder: remove unnecessary code.
76407bc 
Fixes Coverity issue about unused variable.
@Tharazi97
thread_mle_message_handler: fix null comparison.
a60df63 
Fixes Coverity issue about comparing nullptr.
@ciarmcom ciarmcom requested review from a team September 24, 2019 11:00
@ciarmcom
Copy link
Member

@Tharazi97, thank you for your changes.
@ARMmbed/mbed-os-maintainers @ARMmbed/mbed-os-mesh @ARMmbed/mbed-os-wan please review.

@ciarmcom ciarmcom requested a review from a team September 24, 2019 11:00
mikter
mikter reviewed Sep 25, 2019
View reviewed changes
Copy link

@mikter mikter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for me @JarkkoPaso could you check and verify as this affects our releasing

@JarkkoPaso
Copy link

@mikter Yes, we need the changes to private repository too.

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 30, 2019

CI started

@juhhei01
Copy link
Contributor

juhhei01 commented Sep 30, 2019 •
edited
Loading

Hi Who is fixing those Nanostack issues to it own Branch where we first development stuff. @mikter and @JarkkoPaso

@mbed-ci
Copy link

mbed-ci commented Sep 30, 2019

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_cloud-client-test

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 30, 2019

all green now.

Hi Who is fixing those Nanostack issues to it own Branch where we first development stuff. @mikter and @JarkkoPaso

Is this fine to integrate?

@adbridge adbridge merged commit 5108f91 into ARMmbed:master Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikter mikter mikter left review comments

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
release-version: 5.14.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Tharazi97 @ciarmcom @JarkkoPaso @0xc0170 @juhhei01 @mbed-ci @mikter @adbridge