Explicitly set tdb internal flash size for PSoC6 Targets #11560
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default computation assumes that a flash sector is several times larger than a flash page. On PSoC 6 targets this is not the case (the two values are the same) so the computed size is too small. This is a similar change to 1b1f14d, but for devices which implement TDB in internal storage.
|
@kyle-cypress, thank you for your changes. |
VeijoPesonen
approved these changes
Sep 25, 2019
0xc0170
approved these changes
Sep 25, 2019
|
CI started |
Test run: FAILEDSummary: 2 of 4 test jobs failed Failed test jobs:
|
|
Is the failure an internal CI issue? The log shows a segfault while compiling for NRF52840_DK, which should be impacted by this change. |
|
CI restarted |
Test run: FAILEDSummary: 3 of 4 test jobs failed Failed test jobs:
|
|
Seems like master has a problem, investigating cc @ARMmbed/mbed-os-maintainers |
|
Ci restarted, should be good now |
Test run: FAILEDSummary: 1 of 4 test jobs failed Failed test jobs:
|
|
Restarted again |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The default computation comes up with a size that is too small on PSoC 6 devices. This is a similar change to #11298, but for PSoC 6 boards which implement TDB in internal storage.
Pull request type
@ARMmbed/team-cypress
Reviewers
@ARMmbed/team-cypress
Release Notes