Fix ARMC6 linker error for the bare metal profile #11564
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ARMC6 compiler inadvertently introduces the `_scanf_mbtowc` symbol to the build. The commit provides a weak definition of the symbol to satisfy the linker whenever the symbol is included. This affects ARM Compiler 6 version 6.12 and earlier. The compiler error was previously observed when the MICROLIB library is used with the uARM toolchain. However, the weak definition was put in `mbed-os/rtos` which is not included when the bare metal profile is used.
|
@hugueskamba, thank you for your changes. |
0xc0170
approved these changes
Sep 25, 2019
|
@ARMmbed/mbed-os-test baremetal build in CI to catch errors like these? |
kjbracey
approved these changes
Sep 25, 2019
|
CI started |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To reproduce the error, build
mbed-os-example-blinky-baremetalwith the following command using themasterbranch of Mbed OS:mbed compile -t arm -m NUCLEO_F042K6The ARMC6 compiler inadvertently introduces the
_scanf_mbtowcsymbolto the build. The commit provides a weak definition of the symbol to
satisfy the linker whenever the symbol is included. This affects ARM
Compiler 6 version 6.12 and earlier.
The compiler error was previously observed when the MICROLIB library is
used with the uARM toolchain. However, the weak definition was put in
mbed-os/rtoswhich is not included when the bare metal profile is used.Pull request type
Reviewers
@evedon @kjbracey-arm @0xc0170
Release Notes