NRF52: Fixed missing guard in port_api.c #11585
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@marcemmers, thank you for your changes. |
0xc0170
approved these changes
Sep 30, 2019
0xc0170
requested changes
Sep 30, 2019
| @@ -132,3 +134,5 @@ int port_read(port_t *obj) | |||
| { | |||
| return ((m_ports[obj->port]->IN) & obj->mask); | |||
| } | |||
|
|
|||
| #endif // DEVICE_PORTIN || DEVICE_PORTOUT || DEVICE_PORTINOUT | |||
There was a problem hiding this comment.
Can you add a newline at the end of a file (as it was) ?
0xc0170
approved these changes
Sep 30, 2019
|
CI started |
Test run: FAILEDSummary: 2 of 11 test jobs failed Failed test jobs:
|
|
CI restarted, all good now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A device definition guard is missing in the nrf port_api.c file. This adds the missing guard.
Pull request type