Skip to content

Add mbed-os-example-pelion #11588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Conversation

adbridge
Copy link
Contributor

Description

Add pelion example to the examples.json list. Primarily so that this example can be updated automatically with a pull request when updating Mbed OS version.
Set to compile in the CI but not export or test.

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[x] Test update
[ ] Breaking change

Reviewers

Release Notes

Primarily so that this example can be updated automatically with
a pull request when updating Mbed OS version.
Set to compile in the CI but not export or test.
@0xc0170
Copy link
Contributor

0xc0170 commented Sep 30, 2019

CI started

"compile" : true,
"export": false,
"test" : false,
"baud_rate": 9600,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

baud_rate is wrong. Should be 115200

@mbed-ci
Copy link

mbed-ci commented Sep 30, 2019

Test run: FAILED

Summary: 4 of 4 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_unittests
  • jenkins-ci/mbed-os-ci_build-GCC_ARM
  • jenkins-ci/mbed-os-ci_build-IAR
  • jenkins-ci/mbed-os-ci_build-ARM

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 30, 2019

Will restart CI once the above review comment is resolved

@0Grit
Copy link

0Grit commented Oct 10, 2019

bump

@adbridge
Copy link
Contributor Author

CI started

@mbed-ci
Copy link

mbed-ci commented Oct 11, 2019

Test run: FAILED

Summary: 3 of 4 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-ARM
  • jenkins-ci/mbed-os-ci_build-IAR
  • jenkins-ci/mbed-os-ci_build-GCC_ARM

@adbridge
Copy link
Contributor Author

Suspected CI issue, restarted

@mbed-ci
Copy link

mbed-ci commented Oct 11, 2019

Test run: FAILED

Summary: 3 of 4 test jobs failed
Build number : 3
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-IAR
  • jenkins-ci/mbed-os-ci_build-GCC_ARM
  • jenkins-ci/mbed-os-ci_build-ARM

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 14, 2019

CI restarted

@mbed-ci
Copy link

mbed-ci commented Oct 14, 2019

Test run: FAILED

Summary: 3 of 4 test jobs failed
Build number : 4
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-IAR
  • jenkins-ci/mbed-os-ci_build-GCC_ARM
  • jenkins-ci/mbed-os-ci_build-ARM

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 14, 2019

The failures are expected, aren't they?

From https://github.com/ARMmbed/mbed-os-example-pelion#supported-platforms , there are only couple of supported platforms. The tests are passing for this. Shouldn't this example be tested with targets based on this table?

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 14, 2019

@teetak01 Please review ^^

@teetak01
Copy link
Contributor

This should be tested vs. all boards present in the mbed_app.json. I suggest a dynamic parsing of that.

According to mbed_app.json in the example itself only these specific targets are listed.
"K64F", "K66F", "NUCLEO_F429ZI", "UBLOX_EVK_ODIN_W2", "NUCLEO_F411RE", "DISCO_L475VG_IOT01A"
@adbridge
Copy link
Contributor Author

This should be tested vs. all boards present in the mbed_app.json. I suggest a dynamic parsing of that.

That would require significant updates to the CI tools so doubt that is going to happen. I have added:
K64F, K66F, NUCLEO_F429ZI, UBLOX_EVK_ODIN_W2, NUCLEO_F411RE and DISCO_L475VG_IOT01A into here.

@adbridge
Copy link
Contributor Author

CI started

@mbed-ci
Copy link

mbed-ci commented Oct 14, 2019

Test run: FAILED

Summary: 3 of 4 test jobs failed
Build number : 5
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-ARM
  • jenkins-ci/mbed-os-ci_build-IAR
  • jenkins-ci/mbed-os-ci_build-GCC_ARM

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 14, 2019

Failures look better now

[Error] mbed_cloud_dev_credentials.c@22,2: "Replace mbed_cloud_dev_credentials.c with your own developer cert."
[ERROR] ./mbed_cloud_dev_credentials.c:22:2: error: "Replace mbed_cloud_dev_credentials.c with your own developer cert."
#error "Replace mbed_cloud_dev_credentials.c with your own developer cert."

How to fix this one in our CI env?

@trowbridgec
Copy link

@adbridge
Can you also add the EP_AGORA target to your CI testing? We have a PR (ARMmbed/mbed-os-example-pelion#21) in to add our target to the mbed-os-example-pelion app.

@adbridge
Copy link
Contributor Author

@adbridge
Canr you also add the EP_AGORA target to your CI testing? We have a PR (ARMmbed/mbed-os-example-pelion#21) in to add our target to the mbed-os-example-pelion app.

@trowbridgec We can't add that board here until we have it in our CI I'm afraid.

@trowbridgec
Copy link

@adbridge: @maclobdell just received our boards in for CI and is in the process of testing them right now. Assuming he gives them the green light, can the EP_AGORA target be added?

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 18, 2019

@adbridge: @maclobdell just received our boards in for CI and is in the process of testing them right now. Assuming he gives them the green light, can the EP_AGORA target be added?

It definitely can be. Let @maclobdell request that via our test team to make sure it is in CI and we can add it to examples right after.

@mbed-ci
Copy link

mbed-ci commented Oct 18, 2019

Test run: FAILED

Summary: 3 of 4 test jobs failed
Build number : 6
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-IAR
  • jenkins-ci/mbed-os-ci_build-ARM
  • jenkins-ci/mbed-os-ci_build-GCC_ARM

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 21, 2019

I was too quick for CI here. We still need to figure out how to add cert header file. This needs work

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 26, 2019

@adbridge Worth still keeping opened?

@adbridge
Copy link
Contributor Author

@0xc0170 It's still required so I guess we are just waiting on the Pelion / tools guys to work out how to get this working in the CI

@JanneKiiskila
Copy link
Contributor

Yep, we need to get this in. If we can't implement the dynamic target parsing, we need to keep updating the targets as go - once a month or so at least? A regular task we need to keep in mind...

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 11, 2019

@0xc0170 It's still required so I guess we are just waiting on the Pelion / tools guys to work out how to get this working in the CI

@JanneKiiskila @adbridge Is there a ticket for this work to track this ? This would be good to have prior 6.0.0rc1 ?

@0xc0170 0xc0170 added the release-version: 6.0.0-alpha-1 First pre-release version of 6.0.0 label Dec 11, 2019
@adbridge
Copy link
Contributor Author

@JanneKiiskila @adbridge Is there a ticket for this work to track this ? This would be good to have prior 6.0.0rc1 ?

Not that I am aware of , this is a Pelion/tools problem as far as I know so would expect them to be working together to work out exactly what the issue is and how to fix it.....

@teetak01
Copy link
Contributor

Wrote a task with decription what is missing; https://jira.arm.com/browse/MBEDOSTEST-910

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 3, 2020

I'll close this, will be reopened once ticket is resolved.

@0xc0170 0xc0170 closed this Jan 3, 2020
@0xc0170 0xc0170 removed needs: work release-version: 6.0.0-alpha-1 First pre-release version of 6.0.0 labels Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants