-
Notifications
You must be signed in to change notification settings - Fork 3k
Add mbed-os-example-pelion #11588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mbed-os-example-pelion #11588
Conversation
Primarily so that this example can be updated automatically with a pull request when updating Mbed OS version. Set to compile in the CI but not export or test.
CI started |
tools/test/examples/examples.json
Outdated
"compile" : true, | ||
"export": false, | ||
"test" : false, | ||
"baud_rate": 9600, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
baud_rate is wrong. Should be 115200
Test run: FAILEDSummary: 4 of 4 test jobs failed Failed test jobs:
|
Will restart CI once the above review comment is resolved |
bump |
Should be 115200
CI started |
Test run: FAILEDSummary: 3 of 4 test jobs failed Failed test jobs:
|
Suspected CI issue, restarted |
Test run: FAILEDSummary: 3 of 4 test jobs failed Failed test jobs:
|
CI restarted |
Test run: FAILEDSummary: 3 of 4 test jobs failed Failed test jobs:
|
The failures are expected, aren't they? From https://github.com/ARMmbed/mbed-os-example-pelion#supported-platforms , there are only couple of supported platforms. The tests are passing for this. Shouldn't this example be tested with targets based on this table? |
@teetak01 Please review ^^ |
This should be tested vs. all boards present in the mbed_app.json. I suggest a dynamic parsing of that. |
According to mbed_app.json in the example itself only these specific targets are listed. "K64F", "K66F", "NUCLEO_F429ZI", "UBLOX_EVK_ODIN_W2", "NUCLEO_F411RE", "DISCO_L475VG_IOT01A"
That would require significant updates to the CI tools so doubt that is going to happen. I have added: |
CI started |
Test run: FAILEDSummary: 3 of 4 test jobs failed Failed test jobs:
|
Failures look better now
How to fix this one in our CI env? |
@adbridge |
@trowbridgec We can't add that board here until we have it in our CI I'm afraid. |
@adbridge: @maclobdell just received our boards in for CI and is in the process of testing them right now. Assuming he gives them the green light, can the |
It definitely can be. Let @maclobdell request that via our test team to make sure it is in CI and we can add it to examples right after. |
Test run: FAILEDSummary: 3 of 4 test jobs failed Failed test jobs:
|
I was too quick for CI here. We still need to figure out how to add cert header file. This needs work |
@adbridge Worth still keeping opened? |
@0xc0170 It's still required so I guess we are just waiting on the Pelion / tools guys to work out how to get this working in the CI |
Yep, we need to get this in. If we can't implement the dynamic target parsing, we need to keep updating the targets as go - once a month or so at least? A regular task we need to keep in mind... |
@JanneKiiskila @adbridge Is there a ticket for this work to track this ? This would be good to have prior 6.0.0rc1 ? |
Not that I am aware of , this is a Pelion/tools problem as far as I know so would expect them to be working together to work out exactly what the issue is and how to fix it..... |
Wrote a task with decription what is missing; https://jira.arm.com/browse/MBEDOSTEST-910 |
I'll close this, will be reopened once ticket is resolved. |
Description
Add pelion example to the examples.json list. Primarily so that this example can be updated automatically with a pull request when updating Mbed OS version.
Set to compile in the CI but not export or test.
Pull request type
Reviewers
Release Notes