AT_CellularDevice.cpp - unused variable err warning #11598
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JanneKiiskila, thank you for your changes. |
We get this compiler warning; Compile [ 7.9%]: AT_CellularDevice.cpp [Warning] AT_CellularDevice.cpp@206,18: variable 'err' set but not used [-Wunused-but-set-variable] Due to the fact, that the code that would actually use this variable is behind trace flags. Based on review feedback from Antti Kauppila and Kimmo Väisänen, adding same flagging also for that. - Reason being - the operation needs to be within the locks.
JanneKiiskila
force-pushed
the
AT_Cell_err_warn
branch
from
1fc7c18 to
55f6518
Compare
|
Understood, new fix pushed in (git commit --amend), commit message updated to explain the reasoning and give credit to you handsome fellas. |
0xc0170
approved these changes
Sep 30, 2019
kivaisan
approved these changes
Oct 1, 2019
AnttiKauppila
approved these changes
Oct 1, 2019
|
CI started |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We get this compiler warning;
Due to the fact, that the code that would actually use this variable
is behind trace flags. Moving the definition to be behind that same
flag resolves the issue.
Pull request type
Reviewers
@kivaisan @AnttiKauppila @0xc0170
Release Notes
Remove compiler warning due unused variable in
AT_CellularDevice.cpp.