IOTBTOOL-407 Fix microbit to use Arm C5 #11609
Conversation
Earlier changes introduced a change to default Arm C6, which does not compile the micro library which is based on Mbed 2. This change fixes the compiler version for NRF51_MICROBIT devices.
| @@ -5318,7 +5318,8 @@ | |||
| "inherits": ["MCU_NRF51_16K_S110"], | |||
| "macros_add": ["TARGET_NRF_LFCLK_RC"], | |||
| "release_versions": ["2"], | |||
| "device_name": "nRF51822_xxAA" | |||
| "device_name": "nRF51822_xxAA", | |||
| "supported_toolchains": ["ARMC5", "GCC_ARM"] | |||
There was a problem hiding this comment.
Why only ARMC and GCC and not IAR?
There was a problem hiding this comment.
NRF51_MICROBIT inherits from MCU_NRF51_16K_S110 which inherits from MCU_NRF51_S110 and MCU_NRF51_16K_BASE. MCU_NRF51_S110 is a dead end and does not define a toolchain. So following MCU_NRF51_16K_BASE this inherits from MCU_NRF51, which defines the supported_toolchains as [“ARM", "GCC_ARM”]. This means before my change the supported toolchains were Arm C6 and GCC ARM, but before the change which broke microbit they should have been Arm C5 and GCC ARM. This definition seems to be setup in 2016, which means as best as I can tell this platform has never declared support for IAR.
There was a problem hiding this comment.
I had to check this one as well as I would have assumed nrf51 was supported also by IAR but has not been.
|
@madchutney, thank you for your changes. |
|
CI started |
Test run: FAILEDSummary: 1 of 11 test jobs failed Failed test jobs:
|
| @@ -5318,7 +5318,8 @@ | |||
| "inherits": ["MCU_NRF51_16K_S110"], | |||
| "macros_add": ["TARGET_NRF_LFCLK_RC"], | |||
| "release_versions": ["2"], | |||
| "device_name": "nRF51822_xxAA" | |||
| "device_name": "nRF51822_xxAA", | |||
| "supported_toolchains": ["ARMC5", "GCC_ARM"] | |||
There was a problem hiding this comment.
I had to check this one as well as I would have assumed nrf51 was supported also by IAR but has not been.
|
Exporters restarted |
|
I restarted the entire pipeline accidentally 😞 |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
Description
Earlier changes introduced a change to default Arm C6, which does not compile the micro library which is based on Mbed 2. This change fixes the compiler version for NRF51_MICROBIT devices.
https://jira.arm.com/browse/IOTBTOOL-407
Pull request type