Fix enum type to align with psa-arch-tests #11620
Merged
+33
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is related to ARMmbed#11256 When TARGET_PSA is enabled on Cortex-A boards, the SECURE is redeclared. So to minimize the impact we can redeclare this in val.h which is used only by Mbed. And `security_t` itself is used in mbed-os\components\TARGET_PSA\TESTS, but the SECURE string is not used. Renamed to `caller_security_t` which aligns with https://github.com/ARM-software/psa-arch-tests
jainvikas8
changed the title
|
@jainvikas8, thank you for your changes. |
jainvikas8
changed the title
|
@jamesbeyond Please, could you review it. Thanks. |
adbridge
previously requested changes
Oct 7, 2019
| } security_t; | ||
| CALLER_NONSECURE = 0x0, | ||
| CALLER_SECURE = 0x1, | ||
| } caller_security_t; |
There was a problem hiding this comment.
Is this changing actual enumerated types used by a developer ? Or is val.h a test only header file ?
There was a problem hiding this comment.
val.h is a test only header file.
0xc0170
reviewed
Oct 18, 2019
jamesbeyond
approved these changes
Oct 21, 2019
|
@jainvikas8 please confirm this is backward compatible change. I'll start CI meanwhile |
There are NO API changes here. It is internal to test only code. So it should be backward compatible. |
Patater
approved these changes
Oct 21, 2019
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to #11256
When TARGET_PSA is enabled on Cortex-A boards, the SECURE
is redeclared. So to minimize the impact we can redeclare this in
val.h which is used only by Mbed. And
security_titself is used inmbed-os\components\TARGET_PSA\TESTS, but the SECURE string is not used.