Make devicekey remainder test more meaningful #11628
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of 722628b, the "remainder" configuration also uses the default location near the end of flash. Which makes the two tests nearly identical with the exception that the "last two sectors" test correctly handles parts with a low (possibly 1:1) erase size to program size ratio. Therefore, change the "remainder" test to instead be a "default" test that uses the tdb_internal_address/size values, so that it a.) tests something meaningfully different and b.) tests using the custom TDB address/size values if they are provided. c.) functions correctly on devices where the default sector-based size computation does not work (e.g. because of the low erase size to program size ratio) and therefore a custom location and size has been specified. The is_conf_tdb_internal variable is unused and therefore removed.
|
@kyle-cypress, thank you for your changes. |
|
@SeppoTakalo please review |
VeijoPesonen
reviewed
Oct 9, 2019
| @@ -50,7 +50,7 @@ static inline uint32_t align_down(uint64_t val, uint64_t size) | |||
| return (((val) / size)) * size; | |||
| } | |||
|
|
|||
| int get_virtual_TDBStore_position(uint32_t conf_start_address, uint32_t conf_size, bool is_conf_tdb_internal, | |||
| int get_virtual_TDBStore_position(uint32_t conf_start_address, uint32_t conf_size, bool is_conf_tdbd_internal, | |||
There was a problem hiding this comment.
The parameter doesn't seem to be used for anything actually.
There was a problem hiding this comment.
Agreed - I think this is a vestige from the old version of the test prior to 722628b . I'll push another commit to remove.
There was a problem hiding this comment.
Removed the unused parameter
kyle-cypress
force-pushed
the
pr/directaccess-devicekey-test
branch
from
e4cd4a0 to
1cb6f7b
Compare
adbridge
approved these changes
Oct 15, 2019
0xc0170
approved these changes
Oct 15, 2019
|
I restarted Travis and started CI |
Test run: SUCCESSSummary: 5 of 5 test jobs passed |
SeppoTakalo
approved these changes
Oct 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As of 722628b, the "remainder" configuration also uses the default location near the end of flash. Which makes the two tests nearly identical with the exception that the "last two sectors" test correctly handles parts with a low (possibly 1:1) erase size to program size ratio.
Therefore, change the "remainder" test to instead be a "default" test that uses the tdb_internal_address/size values, so that it
a.) tests something meaningfully different
b.) tests using the custom TDB address/size values if they are provided.
c.) functions correctly on devices where the default sector-based size computation does not work (e.g. because of the low erase size to program size ratio) and therefore a custom location and size has been specified.
The is_conf_tdb_internal variable is unused and therefore removed.
Pull request type
Reviewers
Release Notes