Cellular: Change visibility of _is_connected as protected #11630
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AT_CellularContext::do_connect() is a virtual API and therefore can be overwritten in inherited class. The problem was that it sets AT_CellularContext::_is_connected flag but earlier it was set as private member making it impossible to set in overwritten do_connect() method. This commit fixes the problem by changing _is_connected as protected enabling its use in inherited class.
bulislaw
approved these changes
Oct 4, 2019
AnttiKauppila
approved these changes
Oct 10, 2019
|
CI started |
Test run: FAILEDSummary: 1 of 11 test jobs failed Failed test jobs:
|
|
Exporters restarted |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
AT_CellularContext::do_connect()is a virtual API and therefore can be overwritten ininherited class. The problem was that it sets
AT_CellularContext::_is_connectedflag butearlier it was set as private member making it impossible to set in overwritten
do_connect()method.
This commit fixes the problem by changing
_is_connectedas protected enabling its usein inherited class.
This is a fix for issue #11606.
Pull request type
Reviewers
@AriParkkila @mudassar-ublox
Release Notes