Skip to content

Clearing UART TC Flag prevents deep sleep, so do not clear it #11688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 17, 2019
Merged

Clearing UART TC Flag prevents deep sleep, so do not clear it #11688

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions targets/TARGET_STM/TARGET_STM32F0/serial_device.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -569,13 +569,6 @@ uint8_t serial_rx_active(serial_t *obj)
return (((HAL_UART_GetState(huart) & HAL_UART_STATE_BUSY_RX) == HAL_UART_STATE_BUSY_RX) ? 1 : 0);
}

void HAL_UART_TxCpltCallback(UART_HandleTypeDef *huart)
{
if (__HAL_UART_GET_FLAG(huart, UART_FLAG_TC) != RESET) {
__HAL_UART_CLEAR_FLAG(huart, UART_CLEAR_TCF);
}
}

void HAL_UART_ErrorCallback(UART_HandleTypeDef *huart)
{
if (__HAL_UART_GET_FLAG(huart, UART_FLAG_PE) != RESET) {
Expand Down Expand Up @@ -684,9 +677,6 @@ void serial_tx_abort_asynch(serial_t *obj)
__HAL_UART_DISABLE_IT(huart, UART_IT_TC);
__HAL_UART_DISABLE_IT(huart, UART_IT_TXE);

// clear flags
__HAL_UART_CLEAR_FLAG(huart, UART_CLEAR_TCF);

// reset states
huart->TxXferCount = 0;
// update handle state
Expand Down
10 changes: 0 additions & 10 deletions targets/TARGET_STM/TARGET_STM32F1/serial_device.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -443,13 +443,6 @@ uint8_t serial_rx_active(serial_t *obj)
return (((HAL_UART_GetState(huart) & HAL_UART_STATE_BUSY_RX) == HAL_UART_STATE_BUSY_RX) ? 1 : 0);
}

void HAL_UART_TxCpltCallback(UART_HandleTypeDef *huart)
{
if (__HAL_UART_GET_FLAG(huart, UART_FLAG_TC) != RESET) {
__HAL_UART_CLEAR_FLAG(huart, UART_FLAG_TC);
}
}

void HAL_UART_ErrorCallback(UART_HandleTypeDef *huart)
{
if (__HAL_UART_GET_FLAG(huart, UART_FLAG_PE) != RESET) {
Expand Down Expand Up @@ -555,9 +548,6 @@ void serial_tx_abort_asynch(serial_t *obj)
__HAL_UART_DISABLE_IT(huart, UART_IT_TC);
__HAL_UART_DISABLE_IT(huart, UART_IT_TXE);

// clear flags
__HAL_UART_CLEAR_FLAG(huart, UART_FLAG_TC);

// reset states
huart->TxXferCount = 0;
// update handle state
Expand Down
10 changes: 0 additions & 10 deletions targets/TARGET_STM/TARGET_STM32F2/serial_device.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -526,13 +526,6 @@ uint8_t serial_rx_active(serial_t *obj)
return (((HAL_UART_GetState(huart) & HAL_UART_STATE_BUSY_RX) == HAL_UART_STATE_BUSY_RX) ? 1 : 0);
}

void HAL_UART_TxCpltCallback(UART_HandleTypeDef *huart)
{
if (__HAL_UART_GET_FLAG(huart, UART_FLAG_TC) != RESET) {
__HAL_UART_CLEAR_FLAG(huart, UART_FLAG_TC);
}
}

void HAL_UART_ErrorCallback(UART_HandleTypeDef *huart)
{
if (__HAL_UART_GET_FLAG(huart, UART_FLAG_PE) != RESET) {
Expand Down Expand Up @@ -638,9 +631,6 @@ void serial_tx_abort_asynch(serial_t *obj)
__HAL_UART_DISABLE_IT(huart, UART_IT_TC);
__HAL_UART_DISABLE_IT(huart, UART_IT_TXE);

// clear flags
__HAL_UART_CLEAR_FLAG(huart, UART_FLAG_TC);

// reset states
huart->TxXferCount = 0;
// update handle state
Expand Down
11 changes: 0 additions & 11 deletions targets/TARGET_STM/TARGET_STM32F3/serial_device.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,6 @@ void serial_clear(serial_t *obj)
struct serial_s *obj_s = SERIAL_S(obj);
UART_HandleTypeDef *huart = &uart_handlers[obj_s->index];

__HAL_UART_CLEAR_FLAG(huart, UART_CLEAR_TCF);
__HAL_UART_SEND_REQ(huart, UART_RXDATA_FLUSH_REQUEST);
}

Expand Down Expand Up @@ -486,13 +485,6 @@ uint8_t serial_rx_active(serial_t *obj)
return (((HAL_UART_GetState(huart) & HAL_UART_STATE_BUSY_RX) == HAL_UART_STATE_BUSY_RX) ? 1 : 0);
}

void HAL_UART_TxCpltCallback(UART_HandleTypeDef *huart)
{
if (__HAL_UART_GET_FLAG(huart, UART_FLAG_TC) != RESET) {
__HAL_UART_CLEAR_FLAG(huart, UART_CLEAR_TCF);
}
}

void HAL_UART_ErrorCallback(UART_HandleTypeDef *huart)
{
if (__HAL_UART_GET_FLAG(huart, UART_FLAG_PE) != RESET) {
Expand Down Expand Up @@ -601,9 +593,6 @@ void serial_tx_abort_asynch(serial_t *obj)
__HAL_UART_DISABLE_IT(huart, UART_IT_TC);
__HAL_UART_DISABLE_IT(huart, UART_IT_TXE);

// clear flags
__HAL_UART_CLEAR_FLAG(huart, UART_CLEAR_TCF);

// reset states
huart->TxXferCount = 0;
// update handle state
Expand Down
10 changes: 0 additions & 10 deletions targets/TARGET_STM/TARGET_STM32F4/serial_device.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -571,13 +571,6 @@ uint8_t serial_rx_active(serial_t *obj)
return (((HAL_UART_GetState(huart) & HAL_UART_STATE_BUSY_RX) == HAL_UART_STATE_BUSY_RX) ? 1 : 0);
}

void HAL_UART_TxCpltCallback(UART_HandleTypeDef *huart)
{
if (__HAL_UART_GET_FLAG(huart, UART_FLAG_TC) != RESET) {
__HAL_UART_CLEAR_FLAG(huart, UART_FLAG_TC);
}
}

void HAL_UART_ErrorCallback(UART_HandleTypeDef *huart)
{
if (__HAL_UART_GET_FLAG(huart, UART_FLAG_PE) != RESET) {
Expand Down Expand Up @@ -683,9 +676,6 @@ void serial_tx_abort_asynch(serial_t *obj)
__HAL_UART_DISABLE_IT(huart, UART_IT_TC);
__HAL_UART_DISABLE_IT(huart, UART_IT_TXE);

// clear flags
__HAL_UART_CLEAR_FLAG(huart, UART_FLAG_TC);

// reset states
huart->TxXferCount = 0;
// update handle state
Expand Down
10 changes: 0 additions & 10 deletions targets/TARGET_STM/TARGET_STM32F7/serial_device.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -524,13 +524,6 @@ uint8_t serial_rx_active(serial_t *obj)
return (((HAL_UART_GetState(huart) & HAL_UART_STATE_BUSY_RX) == HAL_UART_STATE_BUSY_RX) ? 1 : 0);
}

void HAL_UART_TxCpltCallback(UART_HandleTypeDef *huart)
{
if (__HAL_UART_GET_FLAG(huart, UART_FLAG_TC) != RESET) {
__HAL_UART_CLEAR_IT(huart, UART_CLEAR_TCF);
}
}

void HAL_UART_ErrorCallback(UART_HandleTypeDef *huart)
{
if (__HAL_UART_GET_FLAG(huart, UART_FLAG_PE) != RESET) {
Expand Down Expand Up @@ -639,9 +632,6 @@ void serial_tx_abort_asynch(serial_t *obj)
__HAL_UART_DISABLE_IT(huart, UART_IT_TC);
__HAL_UART_DISABLE_IT(huart, UART_IT_TXE);

// clear flags
__HAL_UART_CLEAR_IT(huart, UART_FLAG_TC);

// reset states
huart->TxXferCount = 0;
// update handle state
Expand Down
10 changes: 0 additions & 10 deletions targets/TARGET_STM/TARGET_STM32H7/serial_device.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -537,13 +537,6 @@ uint8_t serial_rx_active(serial_t *obj)
return (((HAL_UART_GetState(huart) & HAL_UART_STATE_BUSY_RX) == HAL_UART_STATE_BUSY_RX) ? 1 : 0);
}

void HAL_UART_TxCpltCallback(UART_HandleTypeDef *huart)
{
if (__HAL_UART_GET_FLAG(huart, UART_FLAG_TC) != RESET) {
__HAL_UART_CLEAR_IT(huart, UART_CLEAR_TCF);
}
}

void HAL_UART_ErrorCallback(UART_HandleTypeDef *huart)
{
if (__HAL_UART_GET_FLAG(huart, UART_FLAG_PE) != RESET) {
Expand Down Expand Up @@ -652,9 +645,6 @@ void serial_tx_abort_asynch(serial_t *obj)
__HAL_UART_DISABLE_IT(huart, UART_IT_TC);
__HAL_UART_DISABLE_IT(huart, UART_IT_TXE);

// clear flags
__HAL_UART_CLEAR_IT(huart, UART_FLAG_TC);

// reset states
huart->TxXferCount = 0;
// update handle state
Expand Down
10 changes: 0 additions & 10 deletions targets/TARGET_STM/TARGET_STM32L0/serial_device.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -480,13 +480,6 @@ uint8_t serial_rx_active(serial_t *obj)
return (((HAL_UART_GetState(huart) & HAL_UART_STATE_BUSY_RX) == HAL_UART_STATE_BUSY_RX) ? 1 : 0);
}

void HAL_UART_TxCpltCallback(UART_HandleTypeDef *huart)
{
if (__HAL_UART_GET_FLAG(huart, UART_FLAG_TC) != RESET) {
__HAL_UART_CLEAR_FLAG(huart, UART_CLEAR_TCF);
}
}

/**
* The asynchronous TX and RX handler.
*
Expand Down Expand Up @@ -588,9 +581,6 @@ void serial_tx_abort_asynch(serial_t *obj)
__HAL_UART_DISABLE_IT(huart, UART_IT_TC);
__HAL_UART_DISABLE_IT(huart, UART_IT_TXE);

// clear flags
__HAL_UART_CLEAR_FLAG(huart, UART_CLEAR_TCF);

// reset states
huart->TxXferCount = 0;
// update handle state
Expand Down
10 changes: 0 additions & 10 deletions targets/TARGET_STM/TARGET_STM32L1/serial_device.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -479,13 +479,6 @@ uint8_t serial_rx_active(serial_t *obj)
return (((HAL_UART_GetState(huart) & HAL_UART_STATE_BUSY_RX) == HAL_UART_STATE_BUSY_RX) ? 1 : 0);
}

void HAL_UART_TxCpltCallback(UART_HandleTypeDef *huart)
{
if (__HAL_UART_GET_FLAG(huart, UART_FLAG_TC) != RESET) {
__HAL_UART_CLEAR_FLAG(huart, UART_FLAG_TC);
}
}

void HAL_UART_ErrorCallback(UART_HandleTypeDef *huart)
{
if (__HAL_UART_GET_FLAG(huart, UART_FLAG_PE) != RESET) {
Expand Down Expand Up @@ -591,9 +584,6 @@ void serial_tx_abort_asynch(serial_t *obj)
__HAL_UART_DISABLE_IT(huart, UART_IT_TC);
__HAL_UART_DISABLE_IT(huart, UART_IT_TXE);

// clear flags
__HAL_UART_CLEAR_FLAG(huart, UART_FLAG_TC);

// reset states
huart->TxXferCount = 0;
// update handle state
Expand Down
10 changes: 0 additions & 10 deletions targets/TARGET_STM/TARGET_STM32L4/serial_device.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -503,13 +503,6 @@ uint8_t serial_rx_active(serial_t *obj)
return (((HAL_UART_GetState(huart) & HAL_UART_STATE_BUSY_RX) == HAL_UART_STATE_BUSY_RX) ? 1 : 0);
}

void HAL_UART_TxCpltCallback(UART_HandleTypeDef *huart)
{
if (__HAL_UART_GET_FLAG(huart, UART_FLAG_TC) != RESET) {
__HAL_UART_CLEAR_FLAG(huart, UART_FLAG_TC);
}
}

void HAL_UART_ErrorCallback(UART_HandleTypeDef *huart)
{
if (__HAL_UART_GET_FLAG(huart, UART_FLAG_PE) != RESET) {
Expand Down Expand Up @@ -615,9 +608,6 @@ void serial_tx_abort_asynch(serial_t *obj)
__HAL_UART_DISABLE_IT(huart, UART_IT_TC);
__HAL_UART_DISABLE_IT(huart, UART_IT_TXE);

// clear flags
__HAL_UART_CLEAR_FLAG(huart, UART_FLAG_TC);

// reset states
huart->TxXferCount = 0;
// update handle state
Expand Down
10 changes: 0 additions & 10 deletions targets/TARGET_STM/TARGET_STM32WB/serial_device.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -428,13 +428,6 @@ uint8_t serial_rx_active(serial_t *obj)
return (((HAL_UART_GetState(huart) & HAL_UART_STATE_BUSY_RX) == HAL_UART_STATE_BUSY_RX) ? 1 : 0);
}

void HAL_UART_TxCpltCallback(UART_HandleTypeDef *huart)
{
if (__HAL_UART_GET_FLAG(huart, UART_FLAG_TC) != RESET) {
__HAL_UART_CLEAR_FLAG(huart, UART_FLAG_TC);
}
}

void HAL_UART_ErrorCallback(UART_HandleTypeDef *huart)
{
if (__HAL_UART_GET_FLAG(huart, UART_FLAG_PE) != RESET) {
Expand Down Expand Up @@ -540,9 +533,6 @@ void serial_tx_abort_asynch(serial_t *obj)
__HAL_UART_DISABLE_IT(huart, UART_IT_TC);
__HAL_UART_DISABLE_IT(huart, UART_IT_TXE);

// clear flags
__HAL_UART_CLEAR_FLAG(huart, UART_FLAG_TC);

// reset states
huart->TxXferCount = 0;
// update handle state
Expand Down