Changed mbed gpio-port api to match gpio api #11690
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The port configuration api was not correctly setting the port-pins' direction. Changed the port driver to call the gpio driver for configuration (read and write still are optimized for port-level operations) so that the behavior is consistent.
|
@shuopeng-deng, thank you for your changes. |
0xc0170
requested changes
Oct 21, 2019
| obj->port->OUT_CLR = (~value) & obj->mask; | ||
| GPIO_PRT_Type *port_type = Cy_GPIO_PortToAddr(obj->port); | ||
| if (obj->mask == 0xff) | ||
| { |
There was a problem hiding this comment.
can you fix the style, { should be attached in this function as the rest of the file has it
|
Just one styling issue, otherwise looks fine to me |
0xc0170
approved these changes
Oct 21, 2019
|
I was able to fix the styling, starting CI now |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The port configuration api was not correctly setting the port-pins'
direction. Changed the port driver to call the gpio driver for
configuration (read and write still are optimized for port-level
operations) so that the behavior is consistent.
GT-CY8CPROTO_062_4343W-GCC_ARM.txt
GT-CY8CKIT_062_WIFI_BT-GCC_ARM.txt
Pull request type
Reviewers
@ARMmbed/team-cypress
Release Notes