Skip to content

Fix for missing os_cb_section #11699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 18, 2019
Merged

Conversation

rajkan01
Copy link
Contributor

@rajkan01 rajkan01 commented Oct 16, 2019

-Added the os_cb_section stub to remove the warnings

Description

Procedure to reproduce the issue:
1.Clone the blinky bare metal from https://github.com/ARMmbed/mbed-os-example-blinky-baremetal.git
2. Compile the blinky bare metal with "mbed compile -t ARMC6 -m target --profile release"
3.End of the compilation you will notice "[Warning] @0,0: L6320W: Ignoring --keep command. Cannot find argument 'os_cb_sections'." warning.

Reason for the issue:

  1. In release profile, ARMC6 compiler have extra optional argument --keep=os_cb_sections but os_cb_section defined inside RTX RTOS(refer mbed-os/rtos)
    2.For bare metal build we dont have RTX RTOS.

Fix for the issue:

  1. Added the osc_cb_section stub to remove the warnings.

This fixes #11565

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@evedon @hugueskamba

Release Notes

@ciarmcom ciarmcom requested a review from a team October 16, 2019 17:00
@ciarmcom
Copy link
Member

@rajkan01, thank you for your changes.
@ARMmbed/mbed-os-core @ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested a review from a team October 16, 2019 17:00
@hugueskamba
Copy link
Collaborator

@rajkan01
Please add the following text to the description so the associated GitHub issue can be automatically closed when this is merged.

This fixes #11565

It will also add a reference of this PR in the GitHub issue.

Could you also provide the steps to reproduce the error before we try your fix?

 -Added the os_cb_section stub to remove the warnings
Incorporated the below review comment
 -Repharase source code comment
@rajkan01 rajkan01 force-pushed the feature-os-cb-section branch from 79147a2 to f3b4eb3 Compare October 17, 2019 10:30
@0xc0170
Copy link
Contributor

0xc0170 commented Oct 17, 2019

Travis astyle failed (one space left), please fix

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 18, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Oct 18, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit 70f3cf8 into ARMmbed:master Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Profiles contain RTX symbol (bare metal error)
6 participants