Skip to content

Update issue template #11702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 23, 2019
Merged

Update issue template #11702

merged 2 commits into from
Oct 23, 2019

Conversation

adbridge
Copy link
Contributor

Description

Remove no longer required issue type section and add more required sections for defects

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

@adbridge
Update issue template
500db90 
Remove no longer required issue type section and add more required sections for defects
@adbridge adbridge requested a review from 0xc0170 October 17, 2019 10:47
@ciarmcom ciarmcom requested a review from a team October 17, 2019 11:00
@ciarmcom
Copy link
Member

@adbridge, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 17, 2019 •
edited
Loading

Would also this help us : https://help.github.com/en/articles/about-issue-and-pull-request-templates ? I've noticed a report that we are using old template and should update.

We could have "Bug report" only there, and that is it?

0xc0170
0xc0170 reviewed Oct 17, 2019
View reviewed changes
.github/issue_template.md
#### What version of Mbed-os are you using (tag or sha) ?


#### How is this defect reproduced ?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No "tools" section as previously was there?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean by tools section? Version of mbed cli ? etc ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it used to be there. We removing this one?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can add that in

@ciarmcom ciarmcom requested a review from a team October 17, 2019 13:00
@ciarmcom
Copy link
Member

@adbridge, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@adbridge
Copy link
Contributor Author

Would also this help us : https://help.github.com/en/articles/about-issue-and-pull-request-templates ? I've noticed a report that we are using old template and should update.

We could have "Bug report" only there, and that is it?

Will require some additional work to investigate what we need to do to move over to their new method. If we want to move quickly on this for now I suggest sticking with the method we have . We can always add a ticket to do an analysis

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 18, 2019 •
edited
Loading

I'll add a ticket for the update

Update: created internal ticket IOTMAINTAIN-72

0xc0170
0xc0170 approved these changes Oct 18, 2019
View reviewed changes
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just making sure we do not want "tools version" in the bug report as it used to be there for consideration.

@0xc0170 0xc0170 requested a review from bulislaw October 21, 2019 13:04
@0xc0170
Copy link
Contributor

0xc0170 commented Oct 23, 2019

CI started meanwhile

NeilJackson-AlifSemi
NeilJackson-AlifSemi approved these changes Oct 23, 2019
View reviewed changes
Copy link

@NeilJackson-AlifSemi NeilJackson-AlifSemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@0xc0170 0xc0170 merged commit a7d95dd into master Oct 23, 2019
@0xc0170 0xc0170 deleted the issue_template branch October 23, 2019 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@NeilJackson-AlifSemi NeilJackson-AlifSemi NeilJackson-AlifSemi approved these changes

@bulislaw bulislaw Awaiting requested review from bulislaw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adbridge @ciarmcom @0xc0170 @NeilJackson-AlifSemi