Skip to content

Split integration tests for filesystem and network #11703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Split integration tests for filesystem and network #11703

wants to merge 1 commit into from

Conversation

MarceloSalazar
Copy link

@MarceloSalazar MarceloSalazar commented Oct 17, 2019

Description

This PR splits integration tests to let developers run individual tests for filesystem, network or stress (fs+net) depending on what the platform supports.

This is an example of platforms and tests that can be run:

fs-single net-single stress (fs+net)
K64F (sd+eth) ✔️ ✔️ ✔️
NUCLEO_F429ZI (eth) ✔️
DISCO_L496AG (qspi) ✔️

The way to run the integration tests has not changed, but no valid test cases are now skipped.
mbed test -t <toolchain> -m <target> -DINTEGRATION_TESTS

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[X] Test update
[ ] Breaking change

Reviewers

@jamesbeyond

FYI @maclobdell @toyowata

@ciarmcom ciarmcom requested review from jamesbeyond, maclobdell, toyowata and a team October 17, 2019 17:00
@ciarmcom
Copy link
Member

@MarceloSalazar, thank you for your changes.
@jamesbeyond @toyowata @maclobdell @ARMmbed/mbed-os-maintainers please review.

Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add also details in the commit message.

I would suggest moving tests one commit, removal of flashiap another one - two separate things.

@MarceloSalazar
Copy link
Author

Discussed with @jamesbeyond and agreed to re-enable flashiap.

@0xc0170 this is ready for review - hopefully on time for code freeze ;-)

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 11, 2019

CI started meanwhile

@mbed-ci
Copy link

mbed-ci commented Nov 11, 2019

Test run: FAILED

Summary: 2 of 4 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-IAR
  • jenkins-ci/mbed-os-ci_build-GCC_ARM

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 12, 2019

CI restarted

@mbed-ci
Copy link

mbed-ci commented Nov 12, 2019

Test run: SUCCESS

Summary: 5 of 5 test jobs passed
Build number : 2
Build artifacts

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 12, 2019

Travis failed to report , nothing at all. reopen in a second to get a new update

@0xc0170 0xc0170 reopened this Nov 12, 2019
@0xc0170
Copy link
Contributor

0xc0170 commented Nov 12, 2019

I can't find it even on Travis (11703 PR not in the list there , I browsed back to 11700-2 PRs), something went wrong. @MarceloSalazar can you create new PR, that should go quickly in? based on all here.

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 13, 2019

I'll try to close/reopen one more time otherwise we need a new PR :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants