Nrf52 i2c byte rw fix #11739
Merged
Nrf52 i2c byte rw fix #11739
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add tick to us conversion
|
@maciejbocianski, thank you for your changes. |
|
@maciejbocianski Can you add details to 627e6de - amend the commit message. There are new private functions added, how they are fixing the problem ,etc. |
maciejbocianski
force-pushed
the
nrf52_i2c_byte_rw_fix
branch
4 times, most recently
from
bd40d7c to
b1d0c6e
Compare
Any update for this one? |
|
@ARMmbed/team-embeddedplanet |
i2c_byte_write implementation was broken.
Data sending was inside addressing block
Changed from:
i2c_byte_write
{
if (start) {
if (read_address)
start read;
esle
start write;
write byte;
}
}
to:
i2c_byte_write
{
if (start) {
// if first call after start
// address for reading or writing
if (read_address)
start read;
esle
start write;
} else {
// send data byte
write byte;
}
}
maciejbocianski
force-pushed
the
nrf52_i2c_byte_rw_fix
branch
from
b1d0c6e to
703348a
Compare
Updated |
0xc0170
approved these changes
Oct 28, 2019
|
CI started |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix NRF52 i2c read/write single byte implementation
Pull request type
Reviewers
@jamesbeyond
Release Notes