Skip to content

Update the internal kvstore flash reservation size to from 7k to 65K for Cypress Devices #11747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 25, 2019

Conversation

miteshdedhia7
Copy link

@miteshdedhia7 miteshdedhia7 commented Oct 24, 2019

Description

Updated the internal flash available for kvstore from 7K to 65K.
This fixes the features-storage-tests-kvstore-static_tests failure for Cypress devices that do not have external flash capability (QSPIF). The 7K initially allocated is not enough for the devices that use the internal flash for kvstore.
For example, The test fails in the GT reports attached to the PR, #11561
GT test report after fix,
GT_FT_PROTO_063_BLE_GCC.txt

This change should only impact Cypress devices with no external flash.

GT test reports for other devices,
GT_FT_KIT_062_BLE_GCC.txt
GT_FT_KIT_062_WIFI_BT_GCC.txt
GT_FT_KIT_062S2_43012_GCC.txt
GT_FT_KIT_EVB_43012_GCC.txt
GT_FT_PROTO_062_4343W_GCC.txt

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@ARMmbed/team-cypress

Release Notes

@ciarmcom ciarmcom requested review from a team October 24, 2019 23:00
@ciarmcom
Copy link
Member

@miteshdedhia7, thank you for your changes.
@ARMmbed/mbed-os-storage @ARMmbed/mbed-os-maintainers please review.

@0xc0170 0xc0170 requested a review from a team October 25, 2019 10:22
@0xc0170
Copy link
Contributor

0xc0170 commented Oct 25, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Oct 25, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit e1c3de6 into ARMmbed:master Oct 25, 2019
@miteshdedhia7 miteshdedhia7 deleted the pr/fix-kvstore-statictests branch October 25, 2019 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants