Skip to content

M2351: Change base target name 'NU_PFM_M2351_CM' to 'NU_PFM_M2351' #11749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 25, 2019

Conversation

ccli8
Copy link
Contributor

@ccli8 ccli8 commented Oct 25, 2019

Description

This PR changes M2351 base target name from NU_PFM_M2351_CM to NU_PFM_M2351 in targets.json. This is to meet platform name NU_PFM_M2351 registered in mbed-os-tools. This tool uses the platform name as a key to search platform related properties in targets.json. For example, the property forced_reset_timeout is for sync between host and DUT in Greentea test.

Known impact

NUSD driver needs modification to support NU_PFM_M2351 target name, like the update.

Pull request type

[ ] Fix
[ ] Refactor
[x] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

This is to meet platform name 'NU_PFM_M2351' registered in mbed-os-tools. This tool
uses the platform name as a key to search platform related properties in targets.json.
For example, the property 'forced_reset_timeout' is critical for Greentea test.
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The target is private so nothing breaking

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 25, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Oct 25, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants