-
Notifications
You must be signed in to change notification settings - Fork 3k
Cypress: fix GPIO mode NONE #11765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cypress: fix GPIO mode NONE #11765
Conversation
Can you fix "Merge from internal branch (arm-issue-11643)" rather then provide more meaningful commit message. For instance "Cypress: fix gpio mode none" You can add second paragraph to the commit message to describe what you did above about none and strong modes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix commit msg as requested above
@yarbcy Please let us know once updated |
42edceb
to
8055aaa
Compare
8055aaa
to
50b0847
Compare
@0xc0170 I fixed commit message. |
Ci started |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
The CI run only unittests, will check why and should restart |
Restarted CI |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
CI run entire set, just artifacts are missing |
Description (required)
Provide fix for (arm-issue-11643).
#11643
Cypress GPIO pull mode tests fail on CY8CKIT_062_WIFI_B
Summary of change (What the change is for and why)
When PullNone mode, change from CYHAL_GPIO_DRIVE_STRONG -> CYHAL_GPIO_DRIVE_PULL_NONE. Fron now CYHAL_GPIO_DRIVE_PULL_NONE drives CY_GPIO_DM_STRONG when bidirectional or output, CY_GPIO_DM_HIGHZ - when direction is input.
Documentation (Details of any document updates required)
Pull request type (required)
Test results (required)
Reviewers (optional)
Release Notes (required for feature/major PRs)