Change `explicit pinmap` to `static pinmap` #11820

mprse · 2019-11-06T11:06:07Z

Description

Change naming: explicit pinmap to static pinmap.

Pull request type

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Reviewers

@jamesbeyond @0xc0170

ciarmcom · 2019-11-06T12:00:37Z

@mprse, thank you for your changes.
@jamesbeyond @0xc0170 @ARMmbed/mbed-os-maintainers please review.

0xc0170 · 2019-11-08T12:34:53Z

Early CI started

jamesbeyond

LGTM

mbed-ci · 2019-11-08T13:30:04Z

Test run: FAILED

Summary: 3 of 4 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_build-ARM
jenkins-ci/mbed-os-ci_build-IAR
jenkins-ci/mbed-os-ci_build-GCC_ARM

kjbracey

Feels a bit like a misnomer at the HAL level - what the HAL sees is merely an explicit pinmap, and whether it's actually static or not doesn't really matter to it. (It could have been the result of a dynamic lookup).

But from the application/system point of view, it makes sense. So this is fine.

0xc0170 · 2019-11-11T14:57:14Z

Ci restarted (I don't see much in the logs, more likely as CI error)

mbed-ci · 2019-11-11T15:59:26Z

Test run: FAILED

Summary: 3 of 4 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_build-IAR
jenkins-ci/mbed-os-ci_build-ARM
jenkins-ci/mbed-os-ci_build-GCC_ARM

0xc0170 · 2019-11-11T17:26:22Z

@mprse Can you check the logs? I dont see there much from the failures, is this CI/branch error somewhere?

mprse · 2019-11-12T09:16:40Z

ERROR: The mbed tools were not found in "/builds/ws/mbed-os-ci_build-ARM@7/examples/mbed-os-example-blinky". \n You can run "mbed deploy" to install dependencies and tools.\n---\n'

Error: hudson.AbortException: script returned exit code 2

It looks like these failures are not related. I can rebase the feature branch.

0xc0170 · 2019-11-12T09:17:56Z

CI restarted

mbed-ci · 2019-11-12T10:20:47Z

Test run: FAILED

Summary: 3 of 4 test jobs failed
Build number : 3
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_build-ARM
jenkins-ci/mbed-os-ci_build-IAR
jenkins-ci/mbed-os-ci_build-GCC_ARM

mprse · 2019-11-12T11:36:25Z

These failures are caused because the location of examples has changed. Rebase is needed, but it requires a lot of merging. So now I'm testing if it still works after rebase.
@0xc0170 I will provide a rebased feature branch later today (hopefully).

0xc0170 · 2019-11-13T12:24:20Z

CI restarted

I can see unittest failed now. Please review

mbed-ci · 2019-11-13T13:19:30Z

Test run: FAILED

Summary: 2 of 4 test jobs failed
Build number : 4
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_unittests
jenkins-ci/mbed-os-ci_build-ARM

mprse · 2019-11-14T07:30:24Z

Added pwmout_init_direct() stub. Hopefully, this will solve the issue with PWM unit test.

0xc0170 · 2019-11-14T09:09:37Z

Ci restarted

mbed-ci · 2019-11-14T09:53:38Z

Test run: FAILED

Summary: 1 of 4 test jobs failed
Build number : 5
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_build-ARM

mprse · 2019-11-14T10:05:23Z

[2019-11-14T09:27:59.781Z] [mbed] Working path "/builds/ws/mbed-os-ci_build-ARM/examples/mbed-os-example-mbed-crypto" (program)

[2019-11-14T09:27:59.781Z] [EXAMPLES]> INFO     In folder 'mbed-os-example-nfc'

[2019-11-14T09:27:59.781Z] [EXAMPLES]> INFO     Executing command 'mbed-cli deploy'...

[2019-11-14T09:28:02.295Z] [mbed] WARNING: Python 3 is not yet fully supported: Python errors may occur when compiling, testing and exporting

[2019-11-14T09:28:02.295Z] ---

[2019-11-14T09:28:02.295Z] [mbed] ERROR: OS Error: File exists

@jamesbeyond @0xc0170 Do you have any ideas on how to fix this?

0xc0170 · 2019-11-14T10:09:21Z

There was an update to examples (=script - how we test). Also was propagated to CI. I wonder if this branch is older, and might have an issue there?

A rebase should answer this one

mprse · 2019-11-14T10:10:46Z

I have rebased it 3 days ago.

mbed-ci · 2019-11-14T12:15:28Z

Test run: FAILED

Summary: 1 of 4 test jobs failed
Build number : 6
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_build-GCC_ARM

mprse · 2019-11-14T12:23:15Z

Previous failure (example on ARM) is gone. But we got new failures. This time we got other errors on GCC:
Error: java.io.IOException: Can not call launch on a dummy launcher.
https://mbed-os.mbedcloudtesting.com/blue/organizations/jenkins/mbed-os-ci_build-GCC_ARM/detail/mbed-os-ci_build-GCC_ARM/3865/pipeline/368

@0xc0170 @jamesbeyond Since the failures are different in each run I think that we have some CI problem rather than some issue on this branch. 😢
We can try once more.

jamesbeyond · 2019-11-14T12:43:53Z

Previous failure (example on ARM) is gone. But we got new failures. This time we got other errors on GCC:
Error: java.io.IOException: Can not call launch on a dummy launcher.
https://mbed-os.mbedcloudtesting.com/blue/organizations/jenkins/mbed-os-ci_build-GCC_ARM/detail/mbed-os-ci_build-GCC_ARM/3865/pipeline/368

@0xc0170 @jamesbeyond Since the failures are different in each run I think that we have some CI problem rather than some issue on this branch. 😢
We can try once more.

Is this related with GCC9 updates? I'll try to ping CI team and investigation the problem

mprse · 2019-11-14T13:30:11Z

Is this released with GCC9 updates?

I don't know. But results are different in each run.

0xc0170 · 2019-11-14T14:19:06Z

@ARMmbed/mbed-os-test Please help ^^

mprse · 2019-11-15T09:42:07Z

@ARMmbed/mbed-os-test Any updates? Can we move forward with this one?

0xc0170 · 2019-11-15T17:40:01Z

@mprse Please talk to @VeliMattiLahtela

mbed-ci · 2019-11-16T02:22:51Z

Test run: FAILED

Summary: 1 of 12 test jobs failed
Build number : 7
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_greentea-test

mprse · 2019-11-17T09:27:44Z

I see that we have progress. But still, I see some I think unrelated green-tea test failures:

K64F/(all compilers): tests-mbed-crypto-sanity
NUCLEO_F429ZI/ARM: tests-netsocket-dns, tests-netsocket-tls, tests-netsocket-udp, tests-network-interface
NUCLEO_F429ZI/GCC_ARM: tests-netsocket-tcp, tests-network-interface

mbed-ci · 2019-11-17T22:48:01Z

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 8
Build artifacts

mprse · 2019-11-18T09:54:16Z

Tests have passed, but still some Jenkins/pr-merge error:

HTTP ERROR 404
Problem accessing /job/iotsystest-docker-tools/job/mbed-os/job/PR-11820/1/display/redirect. Reason:

    Not Found

0xc0170 · 2019-11-19T07:31:54Z

I'll fix pr merge now and this can go in

ciarmcom requested review from 0xc0170, jamesbeyond and a team November 6, 2019 12:00

ciarmcom added the needs: review label Nov 6, 2019

0xc0170 approved these changes Nov 8, 2019

View reviewed changes

0xc0170 requested a review from kjbracey November 8, 2019 12:34

0xc0170 added the release-version: feature branch label Nov 8, 2019

jamesbeyond approved these changes Nov 8, 2019

View reviewed changes

0xc0170 added needs: CI and removed needs: review labels Nov 8, 2019

kjbracey approved these changes Nov 8, 2019

View reviewed changes

bulislaw approved these changes Nov 12, 2019

View reviewed changes

0xc0170 force-pushed the feature-hal-spec-explicit-pinmap branch from 28dea6d to 4a689ff Compare November 13, 2019 10:46

Change explicit pinmap to static pinmap

32c2a07

mprse force-pushed the explicit_to_static branch from c31b0cc to 32c2a07 Compare November 13, 2019 11:24

0xc0170 added needs: work and removed needs: CI labels Nov 13, 2019

Add pwmout_init_direct() stub (fix for unittests)

25b8101

0xc0170 added needs: CI and removed needs: work labels Nov 14, 2019

0xc0170 removed the needs: CI label Nov 19, 2019

0xc0170 merged commit 3927aae into ARMmbed:feature-hal-spec-explicit-pinmap Nov 19, 2019

Change explicit pinmap to static pinmap #11820

Change explicit pinmap to static pinmap #11820

Uh oh!

Conversation

mprse commented Nov 6, 2019

Description

Pull request type

Reviewers

Uh oh!

ciarmcom commented Nov 6, 2019

Uh oh!

0xc0170 commented Nov 8, 2019

Uh oh!

jamesbeyond left a comment

Choose a reason for hiding this comment

Uh oh!

mbed-ci commented Nov 8, 2019

Uh oh!

kjbracey left a comment

Choose a reason for hiding this comment

Uh oh!

0xc0170 commented Nov 11, 2019

Uh oh!

mbed-ci commented Nov 11, 2019

Uh oh!

0xc0170 commented Nov 11, 2019

Uh oh!

mprse commented Nov 12, 2019

Uh oh!

0xc0170 commented Nov 12, 2019

Uh oh!

mbed-ci commented Nov 12, 2019

Uh oh!

mprse commented Nov 12, 2019

Uh oh!

0xc0170 commented Nov 13, 2019

Uh oh!

mbed-ci commented Nov 13, 2019

Uh oh!

mprse commented Nov 14, 2019

Uh oh!

0xc0170 commented Nov 14, 2019

Uh oh!

mbed-ci commented Nov 14, 2019

Uh oh!

mprse commented Nov 14, 2019

Uh oh!

0xc0170 commented Nov 14, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mprse commented Nov 14, 2019

Uh oh!

mbed-ci commented Nov 14, 2019

Uh oh!

mprse commented Nov 14, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jamesbeyond commented Nov 14, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mprse commented Nov 14, 2019

Uh oh!

0xc0170 commented Nov 14, 2019

Uh oh!

mprse commented Nov 15, 2019

Uh oh!

0xc0170 commented Nov 15, 2019

Uh oh!

mbed-ci commented Nov 16, 2019

Uh oh!

mprse commented Nov 17, 2019

Uh oh!

mbed-ci commented Nov 17, 2019

Uh oh!

mprse commented Nov 18, 2019

Uh oh!

0xc0170 commented Nov 19, 2019

Uh oh!

Uh oh!

Change `explicit pinmap` to `static pinmap` #11820

Change `explicit pinmap` to `static pinmap` #11820

0xc0170 commented Nov 14, 2019 •

edited

Loading

mprse commented Nov 14, 2019 •

edited

Loading

jamesbeyond commented Nov 14, 2019 •

edited

Loading