Skip to content

Fix flag checks to allow disabling unsecure tests #11834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 8, 2019
Merged

Fix flag checks to allow disabling unsecure tests #11834

merged 1 commit into from
Nov 8, 2019

Conversation

kivaisan
Copy link
Contributor

@kivaisan kivaisan commented Nov 7, 2019

Description (required)

Fixed checking of configuration for unsecure tests to allow easier disabling of it. Now unsecure tests can be disabled by just removing MBED_CONF_APP_WIFI_UNSECURE_SSID configuration from json (similar to secure tests).

Summary of change (What the change is for and why)
Documentation (Details of any document updates required)

Pull request type (required)

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results (required)

This is just a test set up configuration change. In CI both secure and unsecure are tested but after this fix, it is easier to run just secure tests.

[X] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers (optional)


Release Notes (required for feature/major PRs)

Summary of changes
Impact of changes
Migration actions required

Now unsecure tests can be disabled by just removing MBED_CONF_APP_WIFI_UNSECURE_SSID
configuration from json.
@ciarmcom ciarmcom requested review from a team November 7, 2019 13:51
@ciarmcom
Copy link
Member

ciarmcom commented Nov 7, 2019

@kivaisan, thank you for your changes.
@ARMmbed/mbed-os-test @ARMmbed/mbed-os-ipcore @ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 8, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Nov 8, 2019

Test run: SUCCESS

Summary: 5 of 5 test jobs passed
Build number : 1
Build artifacts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants