Fix for sending IPv6 UDP packet over link local interface #11877
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AnttiKauppila and @0xc0170 - For review. This fix is required to support mDNS protocol in next mbed-os release (aka 5.15) with IPv4 and IPv6 dual stack configuration. Kindly review. Thanks. |
|
@cy-arsm, thank you for your changes. |
AnttiKauppila
previously requested changes
Nov 18, 2019
kjbracey
reviewed
Nov 18, 2019
UDP packets when IPv4 and IPv6 dual mode stack is enabled and the IPv6 packet is sent over link-local inerface.
kjbracey
approved these changes
Nov 18, 2019
|
@AnttiKauppila can you also approve this pull request if you are ok with the modification. |
|
CI restarted |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
|
@0xc0170 - Hello Martin. Can this be merged and tagged for the coming release. |
|
Hello Martin (@0xc0170) this PR needs your attention. Thanks |
0xc0170
approved these changes
Nov 21, 2019
|
CI started |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (required)
Modified LwIP stack and LwIP mbed-os wrapper to support sending IPv6 UDP packets when IPv4 and IPv6 dual mode stack is enabled and the IPv6 packet is sent over link-local interface
Summary of change (What the change is for and why)
LWIPStack.cpp:
LWIP::socket_sendto( )API checks for valid IPv6 interface before sending the packet using netconn API. This condition check would return NSAPI_ERROR_PARAMETER error, when the UDP packet is sent on IPv6 link local interface. Hence modified the condition check to take address this use case.
lwip_tools.cpp:
convert_mbed_addr_to_lwip() API reset the ip_addr_t address to IPv4 when IP version is NSAPI_UNSPEC. Hence when dual IPv4 and IPv6 stack is enabled, local_ip is set to IPADDR_TYPE_V4.
During UDP packet send the type will be checked for IPADDR_TYPE_ANY since dual stack is enabled.
Hence setting the type to IPADDR_TYPE_ANY is done as part of convert_mbed_addr_to_lwip() when dual stack is enabled.
Pull request type (required)
Test results (required)
Reviewers (optional)
Release Notes (required for feature/major PRs)
Summary of changes
Impact of changes
Migration actions required