Skip to content

Release candidate for mbed-os-5.14.2 #11894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 257 commits into from
Nov 20, 2019
Merged

Release candidate for mbed-os-5.14.2 #11894

merged 257 commits into from
Nov 20, 2019

Conversation

adbridge
Copy link
Contributor

No description provided.

Sathish Kumar Mani and others added 30 commits November 18, 2019 15:42
Problem Statement:
During multicast join sequence, InternetSocket::join_multicast_group() calls InternetSocket::modify_multicast_group(). modify_multicast_group() sets up the multicast group address (i.e., mreq.imr_multiaddr) to be joined and the interface address (i.e., mreq.imr_interface) to be used for the multicast join request. The interface address is initialized with the default value, which sets the version of interface address to NSAPI_UNSPEC. This results in LWIP::setsockopt() API to attempt IPv6 multicast join on the IPv4 interface address, hence IPv6 multicast join always fails with the protocol error.

Fix:
Initialize interface address version based on the multicast address version in LWIP::setsockopt(), before attempting multicast join operation.
Compiler warning fix, trivial. One function has an unused
variable, delete that line.
Sync TWI driver to sdk version 15.3.0 to get rid of data length limitation
AT_CellularContext::do_connect() is a virtual API and therefore can be overwritten in
inherited class. The problem was that it sets AT_CellularContext::_is_connected flag but
earlier it was set as private member making it impossible to set in overwritten do_connect()
method.

This commit fixes the problem by changing _is_connected as protected enabling its use
in inherited class.
Add 2 targets for DISCO_H747I dualcore:
* DISCO_H747I      -> for CM7 core
* DISCO_H747I_CM4  -> for CM4 core

Current restrictions:
* TICKLESS deactivated
* DeepSleep not supported (DeepSleep wrapped to sleep)

Warning: use of the same IP (example I2C1) by both core at the same time is not prevented,
but is strongly not recommended.
Some Hardware Semaphore are use for common IP, to manage concurrent access by both cores: Flash, GPIO, RCC.

Warning: Drag and drop of binary to DISCO_H747I will flash CM7.
         In order to flash CM4, one can use STM32 CubeProgrammer tool.
The BT_DEVICE_WAKE and BT_HOST_WAKE pins were swapped relative to
how the chips are wired up on the board.
Fix the issue as 09f715c in
cybsp_types.h as well.
It is possible to temporarily suspend USB and safely preserve its
configuration. This is needed to allow a device to enter deep
sleep as a USBDevice instance prevents deep sleep. USB operation can be
suspended with `deinit` and restored with `connect`.
The TC flag is used in function serial_is_tx_ongoing to check if there is
an ongoing serial transmission. So this Flag must not be cleared at the
end of the transmission, otherwise, serial_is_tx_ongoing will notify that
TX is ongoing.

The impact is that it may prevent deep sleep to be entered.

Also there is no need to clear this flag at the end of the transaction
because it will be cleared automatically by HW when a new transmission
starts.
…ve for the duration BT device asserts HOST WAKE. This change fixes race condition in Cypress Cordio driver.
- Fixed miscalculation in SPI frequency setup (divider value).
- Added possibility to set up SCK line as NC (usable when SPI peripheral
   is used to handle non-SPI protocols.
- Fixed handlingh of 16-bit (and other >8 bit) transfers.

(cherry picked from commit 7d391f2)
Encourage the usage of consistent types (there are currently
 a mix of `int` and `unsigned int` used for qspi instructions)
QSPI commands are limited to 8 bits, to this is a typdef to char
@0xc0170
Copy link
Contributor

0xc0170 commented Nov 19, 2019

cc @ARMmbed/team-st-mcd ^^ FYI

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 19, 2019

#11711 This one is removing HAL_PCD_EP_Abort function. File USBPhy_STM32 invokes this function and there is no definition.

Assuming 11711 did not fail as on master there is USB update already not using the function in USB. I don't see any dependency in the PR. It needs #11675 that is refactor although in the target code.

How can we fix it @ARMmbed/team-st-mcd ? I would propose to move #11711 to 5.15 (will go out in Dec) - that should fix the failures seen here.

@jeromecoutant
Copy link
Collaborator

Hi
Let's move #11675 to 5.14...?

@adbridge
Copy link
Contributor Author

Hi
Let's move #11675 to 5.14...?

Just tried this and unfortunately it won't patch across (probably has some other dependencies)

@adbridge
Copy link
Contributor Author

Trying a revert of #11711

@adbridge
Copy link
Contributor Author

CI restarted

@mbed-ci
Copy link

mbed-ci commented Nov 19, 2019

Test run: FAILED

Summary: 1 of 4 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-GCC_ARM

@mbed-ci
Copy link

mbed-ci commented Nov 19, 2019

Test run: FAILED

Summary: 1 of 4 test jobs failed
Build number : 3
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-GCC_ARM

Currently mbed-os-example-blinky and mbed-os-example-wifi are built for each and every target in Mbed OS. This will change that only DISCO_L475VG_IOT01A is built for mbed-os-example-wifi. DISCO_L475VG_IOT01A was chosen as its one of the wi-fi supported boards and having integrated wi-fi.
@adbridge
Copy link
Contributor Author

CI restarted

@mbed-ci
Copy link

mbed-ci commented Nov 19, 2019

Test run: FAILED

Summary: 1 of 4 test jobs failed
Build number : 4
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-GCC_ARM

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 20, 2019

[DEBUG] Errors: /usr/local/gcc-arm-none-eabi-6-2017-q1-update/bin/../lib/gcc/arm-none-eabi/6.3.1/../../../../arm-none-eabi/bin/ld: section .text VMA [0000000008000000,000000000800dd47] overlaps section .lwip_sec VMA [0000000000000000,0000000030043fff]

@ARMmbed/team-st-mcd What we are missing? I am investigating

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 20, 2019

PR #11827 added Ethernet support - lwip_sec section was added there. A question is what it needs from master that is not in this release candidate?

@jeromecoutant
Copy link
Collaborator

As you removed all H7 pull requests, you should also removed #11827

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 20, 2019

@jeromecoutant Thanks, that is unfortunate but should fix this one.

The release should be much easier the next year!

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 20, 2019

CI restarted

@mbed-ci
Copy link

mbed-ci commented Nov 20, 2019

Test run: FAILED

Summary: 1 of 12 test jobs failed
Build number : 5
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 20, 2019

[1574249130.32][CONN][RXD] >>> Running case #84: 'SEC_set_write_once_flag_try_remove'...
[1574249130.42][CONN][INF] found KV pair in stream: {{__testcase_start;SEC_set_write_once_flag_try_remove}}, queued...
mbedgt: :298::FAIL: Expected 274 Was 261
[1574249130.61][CONN][RXD] :298::FAIL: Expected 274 Was 261
[1574249130.72][CONN][RXD] >>> failure with reason 'Unknown Failure' during 'Unknown Location'
[1574249130.94][CONN][INF] found KV pair in stream: {{__testcase_finish;SEC_set_write_once_flag_try_remove;0;1}}, queued...
[1574249131.02][CONN][RXD] >>> 'SEC_set_write_once_flag_try_remove': 0 passed, 1 failed with reason 'Test Cases Failed'
[1574249131.02][CONN][RXD]

I dont see this one on nightly. I restarted the tests to confirm:

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 20, 2019

Test passed, lets remember the test case failed and will monitor master

@0xc0170 0xc0170 removed the needs: CI label Nov 20, 2019
@0xc0170 0xc0170 merged commit cf4f12a into mbed-os-5.14 Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.